zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert of Disable SeqNumUnwrapper death tests to avoid breaking downstream builds. (patchset #1 id:1 of https://codereview.chromium.org/2985083002/ )

Browse Source 
Reason for revert:
Creating revert to fix these tests.

Original issue's description:
> Disable SeqNumUnwrapper death tests to avoid breaking downstream builds.
>
> BUG=None
> TBR=stefan@webrtc.org
> NOTRY=true
>
> Review-Url: https://codereview.webrtc.org/2985083002
> Cr-Commit-Position: refs/heads/master@{#19155}
> Committed: 8e245561f2

TBR=stefan@webrtc.org
BUG=None

Review-Url: https://codereview.webrtc.org/2992643002
Cr-Commit-Position: refs/heads/master@{#19166}
This commit is contained in:
philipel
2017-07-27 04:37:18 -07:00
committed by Commit Bot
parent 40e7ebd426
commit 77415f561d
1 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
webrtc/modules/video_coding/sequence_number_util_unittest.cc
View File

@ -209,25 +209,27 @@ TEST_F(TestSeqNumUtil, SeqNumComparatorWithDivisor) {
}
}
// TODO(philipel): Enable when downstream project can hande these death tests.
TEST(SeqNumUnwrapper, DISABLED_NoBackWardWrap) {
#if GTEST_HAS_DEATH_TEST
#if !defined(WEBRTC_ANDROID)
TEST(SeqNumUnwrapper, NoBackWardWrap) {
SeqNumUnwrapper<uint8_t> unwrapper;
EXPECT_EQ(0U, unwrapper.Unwrap(0));
// The unwrapped sequence is not allowed to wrap, if that happens the
// SeqNumUnwrapper should have been constructed with a higher start value.
ASSERT_DEATH_IF_SUPPORTED(unwrapper.Unwrap(255), "");
EXPECT_DEATH(unwrapper.Unwrap(255), "");
}
TEST(SeqNumUnwrapper, DISABLED_NoForwardWrap) {
TEST(SeqNumUnwrapper, NoForwardWrap) {
SeqNumUnwrapper<uint32_t> unwrapper(std::numeric_limits<uint64_t>::max());
EXPECT_EQ(std::numeric_limits<uint64_t>::max(), unwrapper.Unwrap(0));
// The unwrapped sequence is not allowed to wrap, if that happens the
// SeqNumUnwrapper should have been constructed with a lower start value.
ASSERT_DEATH_IF_SUPPORTED(unwrapper.Unwrap(1), "");
EXPECT_DEATH(unwrapper.Unwrap(1), "");
}
#endif
#endif
TEST(SeqNumUnwrapper, ForwardWrap) {
SeqNumUnwrapper<uint8_t> unwrapper;