zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Delete unused use_socket_server argument.

Browse Source 
Bug: webrtc:7723
Change-Id: Ie048f59ed482d509742170cca6c9c1887c58dafd
Reviewed-on: https://webrtc-review.googlesource.com/39507
Reviewed-by: Tommi <tommi@webrtc.org>
Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21649}
This commit is contained in:
Niels Möller
2018-01-15 12:59:43 +01:00
committed by Commit Bot
parent 053c1f8e92
commit 77d3711f08
3 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
rtc_base/nethelpers.cc
View File

@ -84,7 +84,7 @@ int ResolveHostname(const std::string& hostname, int family,
// AsyncResolver // AsyncResolver
AsyncResolver::AsyncResolver() AsyncResolver::AsyncResolver()
: SignalThread(false /* use_socket_server */), error_(-1) {} : SignalThread(), error_(-1) {}
AsyncResolver::~AsyncResolver() = default; AsyncResolver::~AsyncResolver() = default;

4
rtc_base/signalthread.cc
View File

@ -18,9 +18,9 @@ namespace rtc {
// SignalThread // SignalThread
/////////////////////////////////////////////////////////////////////////////// ///////////////////////////////////////////////////////////////////////////////
SignalThread::SignalThread(bool use_socket_server) SignalThread::SignalThread()
: main_(Thread::Current()), : main_(Thread::Current()),
worker_(this, use_socket_server), worker_(this),
state_(kInit), state_(kInit),
refcount_(1) { refcount_(1) {
main_->SignalQueueDestroyed.connect(this, main_->SignalQueueDestroyed.connect(this,

8
rtc_base/signalthread.h
View File

@ -42,7 +42,7 @@ class SignalThread
: public sigslot::has_slots<>, : public sigslot::has_slots<>,
protected MessageHandler { protected MessageHandler {
public: public:
explicit SignalThread(bool use_socket_server = true); SignalThread();
// Context: Main Thread. Call before Start to change the worker's name. // Context: Main Thread. Call before Start to change the worker's name.
bool SetName(const std::string& name, const void* obj); bool SetName(const std::string& name, const void* obj);
@ -104,10 +104,8 @@ class SignalThread
class Worker : public Thread { class Worker : public Thread {
public: public:
explicit Worker(SignalThread* parent, bool use_socket_server) explicit Worker(SignalThread* parent)
: Thread(use_socket_server : Thread(std::unique_ptr<SocketServer>(new NullSocketServer())),
? SocketServer::CreateDefault()
: std::unique_ptr<SocketServer>(new NullSocketServer())),
parent_(parent) {} parent_(parent) {}
~Worker() override; ~Worker() override;
void Run() override; void Run() override;