zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Stats flake] Mark outbound-rtp.framesPerSecond as optional.

Browse Source 
It has been reported that sometimes FPS is undefined, causing the test
to be flaky.

Bug: webrtc:11651
Change-Id: Ieea33833724defa46110aad5d103aa16bfbea861
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176516
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31481}
This commit is contained in:
Henrik Boström
2020-06-10 10:12:13 +02:00
committed by Commit Bot
parent 7649006692
commit 7804c54b97
1 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
pc/rtc_stats_integrationtest.cc
View File

@ -913,8 +913,17 @@ class RTCStatsReportVerifier {
verifier.MarkMemberTested(outbound_stream.content_type, true); verifier.MarkMemberTested(outbound_stream.content_type, true);
verifier.TestMemberIsDefined(outbound_stream.encoder_implementation); verifier.TestMemberIsDefined(outbound_stream.encoder_implementation);
if (enable_simulcast_stats) { if (enable_simulcast_stats) {
verifier.TestMemberIsNonNegative<double>( // Unless an implementation-specific amount of time has passed and at
outbound_stream.frames_per_second); // least one frame has been encoded, undefined is reported. Because it
// is hard to tell what is the case here, we treat FPS as optional.
// TODO(hbos): Update the tests to run until all implemented metrics
// should be populated.
if (outbound_stream.frames_per_second.is_defined()) {
verifier.TestMemberIsNonNegative<double>(
outbound_stream.frames_per_second);
} else {
verifier.TestMemberIsUndefined(outbound_stream.frames_per_second);
}
verifier.TestMemberIsNonNegative<uint32_t>( verifier.TestMemberIsNonNegative<uint32_t>(
outbound_stream.frame_height); outbound_stream.frame_height);
verifier.TestMemberIsNonNegative<uint32_t>(outbound_stream.frame_width); verifier.TestMemberIsNonNegative<uint32_t>(outbound_stream.frame_width);