zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Enabling clang::find_bad_constructs for libjingle_peerconnection_api.

Browse Source 
This CL removes //build/config/clang:find_bad_constructs from the
suppressed_configs list, which means that clang:find_bad_constructs
is now enabled on these translation units.

Bug: webrtc:9251, webrtc:163
Change-Id: I5475e574353c772910181495fdb3400b5f0e7399
Reviewed-on: https://webrtc-review.googlesource.com/87240
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24040}
This commit is contained in:
Mirko Bonadei
2018-07-19 10:39:30 +02:00
committed by Commit Bot
parent 9416ef8c4f
commit 79eb4dd928
14 changed files with 409 additions and 161 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
api/datachannelinterface.h
View File

@ -88,7 +88,7 @@ class DataChannelObserver {
virtual void OnBufferedAmountChange(uint64_t previous_amount) {}
protected:
virtual ~DataChannelObserver() {}
virtual ~DataChannelObserver() = default;
};
class DataChannelInterface : public rtc::RefCountInterface {
@ -134,11 +134,11 @@ class DataChannelInterface : public rtc::RefCountInterface {
// TODO(deadbeef): Remove these dummy implementations when all classes have
// implemented these APIs. They should all just return the values the
// DataChannel was created with.
virtual bool ordered() const { return false; }
virtual uint16_t maxRetransmitTime() const { return 0; }
virtual uint16_t maxRetransmits() const { return 0; }
virtual std::string protocol() const { return std::string(); }
virtual bool negotiated() const { return false; }
virtual bool ordered() const;
virtual uint16_t maxRetransmitTime() const;
virtual uint16_t maxRetransmits() const;
virtual std::string protocol() const;
virtual bool negotiated() const;
// Returns the ID from the DataChannelInit, if it was negotiated out-of-band.
// If negotiated in-band, this ID will be populated once the DTLS role is
@ -170,7 +170,7 @@ class DataChannelInterface : public rtc::RefCountInterface {
virtual bool Send(const DataBuffer& buffer) = 0;
protected:
virtual ~DataChannelInterface() {}
~DataChannelInterface() override = default;
};
} // namespace webrtc