zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Enabling clang::find_bad_constructs for libjingle_peerconnection_api.

Browse Source 
This CL removes //build/config/clang:find_bad_constructs from the
suppressed_configs list, which means that clang:find_bad_constructs
is now enabled on these translation units.

Bug: webrtc:9251, webrtc:163
Change-Id: I5475e574353c772910181495fdb3400b5f0e7399
Reviewed-on: https://webrtc-review.googlesource.com/87240
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24040}
This commit is contained in:
Mirko Bonadei
2018-07-19 10:39:30 +02:00
committed by Commit Bot
parent 9416ef8c4f
commit 79eb4dd928
14 changed files with 409 additions and 161 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
api/rtptransceiverinterface.h
View File

@ -34,6 +34,8 @@ enum class RtpTransceiverDirection {
// PeerConnectionInterface::AddTransceiver.
// https://w3c.github.io/webrtc-pc/#dom-rtcrtptransceiverinit
struct RtpTransceiverInit final {
RtpTransceiverInit();
~RtpTransceiverInit();
// Direction of the RtpTransceiver. See RtpTransceiverInterface::direction().
RtpTransceiverDirection direction = RtpTransceiverDirection::kSendRecv;
@ -112,9 +114,7 @@ class RtpTransceiverInterface : public rtc::RefCountInterface {
// OnAddTrack only get fired once even if the same session description is
// applied again.
// Exposed in the public interface for use by Chromium.
virtual absl::optional<RtpTransceiverDirection> fired_direction() const {
return absl::nullopt;
}
virtual absl::optional<RtpTransceiverDirection> fired_direction() const;
// The Stop method irreversibly stops the RtpTransceiver. The sender of this
// transceiver will no longer send, the receiver will no longer receive.
@ -129,7 +129,7 @@ class RtpTransceiverInterface : public rtc::RefCountInterface {
rtc::ArrayView<RtpCodecCapability> codecs) = 0;
protected:
virtual ~RtpTransceiverInterface() = default;
~RtpTransceiverInterface() override = default;
};
} // namespace webrtc