zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "Avoid using lld when compiling iin iOS with bitcode"

Browse Source 
This reverts commit b7ba6027659913883af3d64ec0fdfcba96176816.

Reason for revert: Speculative revert as this seems to break the downstream project.

Original change's description:
> Avoid using lld when compiling iin iOS with bitcode
>
> The resulting framework's LLVM __bundle segment is empty otherwise.
>
> Bug: webrtc:13774
> Change-Id: I235a3005f8e0d68168f29108be0f7c5b7914182b
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/253140
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#36178}

Bug: webrtc:13774
Change-Id: Ib05469827783d8db5e48ab9c33b31fcebd14b52a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/255302
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36186}
This commit is contained in:
Ilya Nikolaevskiy
2022-03-14 10:22:06 +00:00
committed by WebRTC LUCI CQ
parent d8543dedf2
commit 7c453589a9
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
tools_webrtc/ios/build_ios_libs.py
View File

@ -180,7 +180,6 @@ def BuildWebRTC(output_dir, target_environment, target_arch, flavor,
('true' if libvpx_build_vp9 else 'false'))
gn_args.append('enable_ios_bitcode=' + ('true' if use_bitcode else 'false'))
gn_args.append('use_lld=' + ('false' if use_bitcode else 'true'))
gn_args.append('use_goma=' + ('true' if use_goma else 'false'))
gn_args.append('rtc_enable_objc_symbol_export=true')