zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "Reenable simulcast video full stack test on MAC"

Browse Source 
This reverts commit 2c446f2723451011f8c3ec5d240337e9e309a577.

Reason for revert: Still hangs, e.g. here: https://ci.chromium.org/buildbot/client.webrtc.perf/Mac%2010.11/7204

Original change's description:
> Reenable simulcast video full stack test on MAC
>
> Reenabling test because a possible hanging cause was fixed here:
> https://webrtc-review.googlesource.com/c/src/+/96980
>
> Bug: webrtc:9220
> Change-Id: I74243eeebe5646c54373fba04bff27d456df7771
> Reviewed-on: https://webrtc-review.googlesource.com/98500
> Reviewed-by: Erik Språng <sprang@webrtc.org>
> Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#24624}

TBR=ilnik@webrtc.org,sprang@webrtc.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: webrtc:9220
Change-Id: I172ecec57233131267e38b0221564e6f3f88941f
Reviewed-on: https://webrtc-review.googlesource.com/99180
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24653}
This commit is contained in:
Ilya Nikolaevskiy
2018-09-10 12:04:50 +00:00
committed by Commit Bot
parent 067818fe85
commit 7e5203f151
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
video/full_stack_tests.cc
View File

@ -863,7 +863,8 @@ TEST(FullStackTest, VP9KSVC_3SL_Medium_Network_Restricted) {
#endif // !defined(RTC_DISABLE_VP9)
// Android bots can't handle FullHD, so disable the test.
#if defined(WEBRTC_ANDROID)
// TODO(bugs.webrtc.org/9220): Investigate source of flakiness on Mac.
#if defined(WEBRTC_ANDROID) || defined(WEBRTC_MAC)
#define MAYBE_SimulcastFullHdOveruse DISABLED_SimulcastFullHdOveruse
#else
#define MAYBE_SimulcastFullHdOveruse SimulcastFullHdOveruse