From 7e7a23fea4a0ba2d506af90b42098e098110a258 Mon Sep 17 00:00:00 2001 From: Jakob Ivarsson Date: Tue, 6 Sep 2022 16:43:06 +0200 Subject: [PATCH] Set default audio level header extension value to 127. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Having the minimum value as the default makes more sense than maximum. Bug: b/232103634 Change-Id: Ia6a97f7a2a47bb74ed3b3316d95a1c6d00e2c16b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/274260 Reviewed-by: Danil Chapovalov Commit-Queue: Jakob Ivarsson‎ Cr-Commit-Position: refs/heads/main@{#38021} --- modules/rtp_rtcp/source/rtp_sender_audio.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/rtp_rtcp/source/rtp_sender_audio.h b/modules/rtp_rtcp/source/rtp_sender_audio.h index 6d61facc9a..d40fee6386 100644 --- a/modules/rtp_rtcp/source/rtp_sender_audio.h +++ b/modules/rtp_rtcp/source/rtp_sender_audio.h @@ -62,7 +62,7 @@ class RTPSenderAudio { // Store the audio level in dBov for // header-extension-for-audio-level-indication. - // Valid range is [0,100]. Actual value is negative. + // Valid range is [0,127]. Actual value is negative. int32_t SetAudioLevel(uint8_t level_dbov); // Send a DTMF tone using RFC 2833 (4733) @@ -105,7 +105,7 @@ class RTPSenderAudio { // Audio level indication. // (https://datatracker.ietf.org/doc/draft-lennox-avt-rtp-audio-level-exthdr/) - uint8_t audio_level_dbov_ RTC_GUARDED_BY(send_audio_mutex_) = 0; + uint8_t audio_level_dbov_ RTC_GUARDED_BY(send_audio_mutex_) = 127; OneTimeEvent first_packet_sent_; absl::optional encoder_rtp_timestamp_frequency_