Moved legacy_encoded_audio_frame into audio_decoder_interface.

audio_decoder.cc depends on LegacyEncodedAudioFrame and
LegacyEncodedAudioFrame depends on AudioDecoder::EncodedAudioFrame, so
there's no clear way to separate them as of now. This error is also
hodling up builds downstream. I expect we'll revisit these
dependencies as part of the upcoming larger restructuring effort.

NOTRY=true
BUG=webrtc:5805

Review-Url: https://codereview.webrtc.org/2359763002
Cr-Commit-Position: refs/heads/master@{#14329}

webrtc/modules/BUILD.gn

@@ -237,9 +237,7 @@ if (rtc_include_tests) {
     testonly = true
 
     defines = audio_coding_defines
-    deps = [
-      "audio_coding:legacy_encoded_audio_frame",
-    ]
+    deps = []
     sources = [
       "audio_coding/acm2/acm_receiver_unittest_oldapi.cc",
       "audio_coding/acm2/audio_coding_module_unittest_oldapi.cc",

webrtc/modules/audio_coding/BUILD.gn

@@ -128,9 +128,10 @@ rtc_source_set("audio_decoder_interface") {
   sources = [
     "codecs/audio_decoder.cc",
     "codecs/audio_decoder.h",
+    "codecs/legacy_encoded_audio_frame.cc",
+    "codecs/legacy_encoded_audio_frame.h",
   ]
   deps = [
-    ":legacy_encoded_audio_frame",
     "../..:webrtc_common",
     "../../base:rtc_base_approved",
   ]
@@ -188,13 +189,6 @@ rtc_source_set("red") {
   ]
 }
 
-rtc_source_set("legacy_encoded_audio_frame") {
-  sources = [
-    "codecs/legacy_encoded_audio_frame.cc",
-    "codecs/legacy_encoded_audio_frame.h",
-  ]
-}
-
 config("g711_config") {
   include_dirs = [
     "../../..",
@@ -219,7 +213,6 @@ rtc_source_set("g711") {
   deps = [
     ":audio_decoder_interface",
     ":audio_encoder_interface",
-    ":legacy_encoded_audio_frame",
   ]
 }
 
@@ -248,7 +241,6 @@ rtc_source_set("g722") {
   deps = [
     ":audio_decoder_interface",
     ":audio_encoder_interface",
-    ":legacy_encoded_audio_frame",
   ]
 }
 

webrtc/modules/audio_coding/audio_coding.gypi

@@ -186,26 +186,6 @@
         'include/audio_coding_module_typedefs.h',
       ],
     },
-    {
-      'target_name': 'legacy_encoded_audio_frame',
-      'type': 'static_library',
-      'dependencies': [
-        '<(webrtc_root)/common.gyp:webrtc_common',
-        'audio_decoder_interface',
-      ],
-      'include_dirs': [
-        '<(webrtc_root)',
-      ],
-      'direct_dependent_settings': {
-        'include_dirs': [
-          '<(webrtc_root)',
-        ],
-      },
-      'sources': [
-        'codecs/legacy_encoded_audio_frame.cc',
-        'codecs/legacy_encoded_audio_frame.h',
-      ],
-    },
   ],
   'conditions': [
     ['include_opus==1', {

webrtc/modules/audio_coding/codecs/g711/g711.gypi

@@ -14,7 +14,6 @@
       'dependencies': [
         'audio_encoder_interface',
         'audio_decoder_interface',
-        'legacy_encoded_audio_frame',
       ],
       'sources': [
         'audio_decoder_pcm.cc',

webrtc/modules/audio_coding/codecs/g722/g722.gypi

@@ -13,7 +13,6 @@
       'dependencies': [
         'audio_encoder_interface',
         'audio_decoder_interface',
-        'legacy_encoded_audio_frame',
       ],
       'sources': [
         'audio_decoder_g722.cc',

webrtc/modules/audio_coding/codecs/interfaces.gypi

@@ -14,6 +14,8 @@
       'sources': [
         'audio_decoder.cc',
         'audio_decoder.h',
+        'legacy_encoded_audio_frame.cc',
+        'legacy_encoded_audio_frame.h',
       ],
       'dependencies': [
         '<(webrtc_root)/base/base.gyp:rtc_base_approved',

webrtc/modules/audio_coding/codecs/pcm16b/pcm16b.gypi

@@ -14,7 +14,6 @@
       'dependencies': [
         'audio_encoder_interface',
         'audio_decoder_interface',
-        'legacy_encoded_audio_frame',
         'g711',
       ],
       'sources': [