NetEq: Deprecate playout modes Fax, Off and Streaming
The playout modes other than Normal have not been reachable for a long time, other than through tests. It is time to deprecate them. The only meaningful use was that Fax mode was sometimes set from tests, in order to avoid time-stretching operations (accelerate and pre-emptive expand) from messing with the test results. With this CL, a new config is added instead, which lets the user specify exactly this: don't do time-stretching. As a result of Fax and Off modes being removed, the following code clean-up was done: - Fold DecisionLogicNormal into DecisionLogic. - Remove AudioRepetition and AlternativePlc operations, since they can no longer be reached. Bug: webrtc:9421 Change-Id: I651458e9c1931a99f3b07e242817d303bac119df Reviewed-on: https://webrtc-review.googlesource.com/84123 Commit-Queue: Henrik Lundin <henrik.lundin@webrtc.org> Reviewed-by: Ivo Creusen <ivoc@webrtc.org> Reviewed-by: Minyue Li <minyue@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23704}
This commit is contained in:
committed by
Commit Bot
parent
c0260b4f2b
commit
80c4cca491
@ -33,19 +33,7 @@ TEST(DecisionLogic, CreateAndDestroy) {
|
||||
DelayManager delay_manager(240, &delay_peak_detector, &tick_timer);
|
||||
BufferLevelFilter buffer_level_filter;
|
||||
DecisionLogic* logic = DecisionLogic::Create(
|
||||
fs_hz, output_size_samples, kPlayoutOn, &decoder_database, packet_buffer,
|
||||
&delay_manager, &buffer_level_filter, &tick_timer);
|
||||
delete logic;
|
||||
logic = DecisionLogic::Create(
|
||||
fs_hz, output_size_samples, kPlayoutStreaming, &decoder_database,
|
||||
packet_buffer, &delay_manager, &buffer_level_filter, &tick_timer);
|
||||
delete logic;
|
||||
logic = DecisionLogic::Create(
|
||||
fs_hz, output_size_samples, kPlayoutFax, &decoder_database, packet_buffer,
|
||||
&delay_manager, &buffer_level_filter, &tick_timer);
|
||||
delete logic;
|
||||
logic = DecisionLogic::Create(
|
||||
fs_hz, output_size_samples, kPlayoutOff, &decoder_database, packet_buffer,
|
||||
fs_hz, output_size_samples, false, &decoder_database, packet_buffer,
|
||||
&delay_manager, &buffer_level_filter, &tick_timer);
|
||||
delete logic;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user