zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Expose target bandwidth fraction for transport feedback for field trial

Browse Source 
Bug: None
Change-Id: I5b3db8ff18460ac0bfd5e3db994642a21ba90d9a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/140944
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28210}
This commit is contained in:
Niels Möller
2019-06-10 10:09:54 +02:00
committed by Commit Bot
parent 5d24b16c77
commit 8169db6df2
2 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
modules/remote_bitrate_estimator/remote_estimator_proxy.cc
View File

@ -107,7 +107,8 @@ void RemoteEstimatorProxy::OnBitrateChanged(int bitrate_bps) {
rtc::CritScope cs(&lock_); rtc::CritScope cs(&lock_);
send_interval_ms_ = static_cast<int>( send_interval_ms_ = static_cast<int>(
0.5 + kTwccReportSize * 8.0 * 1000.0 / 0.5 + kTwccReportSize * 8.0 * 1000.0 /
rtc::SafeClamp(0.05 * bitrate_bps, kMinTwccRate, kMaxTwccRate)); rtc::SafeClamp(send_config_.bandwidth_fraction * bitrate_bps,
kMinTwccRate, kMaxTwccRate));
} }
void RemoteEstimatorProxy::SetSendPeriodicFeedback( void RemoteEstimatorProxy::SetSendPeriodicFeedback(

9
modules/remote_bitrate_estimator/remote_estimator_proxy.h
View File

@ -58,12 +58,13 @@ class RemoteEstimatorProxy : public RemoteBitrateEstimator {
FieldTrialParameter<TimeDelta> min_interval{"min", TimeDelta::ms(50)}; FieldTrialParameter<TimeDelta> min_interval{"min", TimeDelta::ms(50)};
FieldTrialParameter<TimeDelta> max_interval{"max", TimeDelta::ms(250)}; FieldTrialParameter<TimeDelta> max_interval{"max", TimeDelta::ms(250)};
FieldTrialParameter<TimeDelta> default_interval{"def", TimeDelta::ms(100)}; FieldTrialParameter<TimeDelta> default_interval{"def", TimeDelta::ms(100)};
FieldTrialParameter<double> bandwidth_fraction{"frac", 0.05};
explicit TransportWideFeedbackConfig( explicit TransportWideFeedbackConfig(
const WebRtcKeyValueConfig* key_value_config) { const WebRtcKeyValueConfig* key_value_config) {
ParseFieldTrial( ParseFieldTrial({&back_window, &min_interval, &max_interval,
{&back_window, &min_interval, &max_interval, &default_interval}, &default_interval, &bandwidth_fraction},
key_value_config->Lookup( key_value_config->Lookup(
"WebRTC-Bwe-TransportWideFeedbackIntervals")); "WebRTC-Bwe-TransportWideFeedbackIntervals"));
} }
}; };