zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove dead version of StartRtcEventLog

Browse Source 
These versions of StartRtcEventLog() are not used.

Bug: webrtc:8111
Change-Id: I1fb543a908decff203b13f8358598f75d875c111
Reviewed-on: https://webrtc-review.googlesource.com/6782
Commit-Queue: Elad Alon <eladalon@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20191}
This commit is contained in:
Elad Alon
2017-10-06 11:34:15 +02:00
committed by Commit Bot
parent 8deb818086
commit 82eb3c4309
3 changed files with 0 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
api/peerconnectionfactoryproxy.h
View File

@ -66,11 +66,6 @@ BEGIN_SIGNALING_PROXY_MAP(PeerConnectionFactory)
CreateAudioTrack, const std::string&, AudioSourceInterface*) CreateAudioTrack, const std::string&, AudioSourceInterface*)
PROXY_METHOD2(bool, StartAecDump, rtc::PlatformFile, int64_t) PROXY_METHOD2(bool, StartAecDump, rtc::PlatformFile, int64_t)
PROXY_METHOD0(void, StopAecDump) PROXY_METHOD0(void, StopAecDump)
// TODO(ivoc): Remove the StartRtcEventLog and StopRtcEventLog functions as
// soon as they are removed from PeerConnectionFactoryInterface.
PROXY_METHOD1(bool, StartRtcEventLog, rtc::PlatformFile)
PROXY_METHOD2(bool, StartRtcEventLog, rtc::PlatformFile, int64_t)
PROXY_METHOD0(void, StopRtcEventLog)
END_PROXY_MAP() END_PROXY_MAP()
} // namespace webrtc } // namespace webrtc

19
api/peerconnectioninterface.h
View File

@ -1028,25 +1028,6 @@ class PeerConnectionFactoryInterface : public rtc::RefCountInterface {
// Stops logging the AEC dump. // Stops logging the AEC dump.
virtual void StopAecDump() = 0; virtual void StopAecDump() = 0;
// This function is deprecated and will be removed when Chrome is updated to
// use the equivalent function on PeerConnectionInterface.
// TODO(ivoc) Remove after Chrome is updated.
virtual bool StartRtcEventLog(rtc::PlatformFile file,
int64_t max_size_bytes) {
return false;
}
// This function is deprecated and will be removed when Chrome is updated to
// use the equivalent function on PeerConnectionInterface.
// TODO(ivoc) Remove after Chrome is updated.
virtual bool StartRtcEventLog(rtc::PlatformFile file) {
return false;
}
// This function is deprecated and will be removed when Chrome is updated to
// use the equivalent function on PeerConnectionInterface.
// TODO(ivoc) Remove after Chrome is updated.
virtual void StopRtcEventLog() {}
protected: protected:
// Dtor and ctor protected as objects shouldn't be created or deleted via // Dtor and ctor protected as objects shouldn't be created or deleted via
// this interface. // this interface.

9
pc/peerconnectionfactory.h
View File

@ -85,15 +85,6 @@ class PeerConnectionFactory : public PeerConnectionFactoryInterface {
bool StartAecDump(rtc::PlatformFile file, int64_t max_size_bytes) override; bool StartAecDump(rtc::PlatformFile file, int64_t max_size_bytes) override;
void StopAecDump() override; void StopAecDump() override;
// TODO(ivoc) Remove after Chrome is updated.
bool StartRtcEventLog(rtc::PlatformFile file) override { return false; }
// TODO(ivoc) Remove after Chrome is updated.
bool StartRtcEventLog(rtc::PlatformFile file,
int64_t max_size_bytes) override {
return false;
}
// TODO(ivoc) Remove after Chrome is updated.
void StopRtcEventLog() override {}
virtual cricket::TransportController* CreateTransportController( virtual cricket::TransportController* CreateTransportController(
cricket::PortAllocator* port_allocator, cricket::PortAllocator* port_allocator,