Android: Use scoped java refs
We currently use raw jobject in our code mixed with sporadic ScopedLocalRefFrame. This CL moves every jobject into a scoped object, either local, global, or a parameter. Also, this CL uses the JNI generation script to generate declaration stubs for the Java->C++ functions so that it no longer becomes possible to mistype them without getting compilation errors. TBR=brandt@webrtc.org Bug: webrtc:8278,webrtc:6969 Change-Id: Ic7bac74a89c11180177d65041086d7db1cdfb516 Reviewed-on: https://webrtc-review.googlesource.com/34655 Commit-Queue: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Sami Kalliomäki <sakal@webrtc.org> Cr-Commit-Position: refs/heads/master@{#21387}
This commit is contained in:
committed by
Commit Bot
parent
ec22e3f503
commit
84d8ae5df7
@ -28,7 +28,7 @@ import java.util.Map;
|
||||
// Most histograms are not updated frequently (e.g. most video metrics are an
|
||||
// average over the call and recorded when a stream is removed).
|
||||
// The metrics can for example be retrieved when a peer connection is closed.
|
||||
|
||||
@JNINamespace("webrtc::jni")
|
||||
public class Metrics {
|
||||
private static final String TAG = "Metrics";
|
||||
|
||||
@ -69,14 +69,14 @@ public class Metrics {
|
||||
// Enables gathering of metrics (which can be fetched with getAndReset()).
|
||||
// Must be called before PeerConnectionFactory is created.
|
||||
public static void enable() {
|
||||
enableNative();
|
||||
nativeEnable();
|
||||
}
|
||||
|
||||
// Gets and clears native histograms.
|
||||
public static Metrics getAndReset() {
|
||||
return getAndResetNative();
|
||||
return nativeGetAndReset();
|
||||
}
|
||||
|
||||
private static native void enableNative();
|
||||
private static native Metrics getAndResetNative();
|
||||
private static native void nativeEnable();
|
||||
private static native Metrics nativeGetAndReset();
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user