diff --git a/webrtc/common_types.h b/webrtc/common_types.h index 1156bbcd77..bda9c7ec50 100644 --- a/webrtc/common_types.h +++ b/webrtc/common_types.h @@ -758,13 +758,12 @@ struct OverUseDetectorOptions { initial_e(), initial_process_noise(), initial_avg_noise(0.0), - initial_var_noise(50), - initial_threshold(25.0) { + initial_var_noise(50) { initial_e[0][0] = 100; initial_e[1][1] = 1e-1; initial_e[0][1] = initial_e[1][0] = 0; initial_process_noise[0] = 1e-13; - initial_process_noise[1] = 1e-3; + initial_process_noise[1] = 1e-2; } double initial_slope; double initial_offset; @@ -772,7 +771,6 @@ struct OverUseDetectorOptions { double initial_process_noise[2]; double initial_avg_noise; double initial_var_noise; - double initial_threshold; }; // This structure will have the information about when packet is actually diff --git a/webrtc/modules/remote_bitrate_estimator/overuse_detector_unittest.cc b/webrtc/modules/remote_bitrate_estimator/overuse_detector_unittest.cc index 1bb28c8d95..c7d129718f 100644 --- a/webrtc/modules/remote_bitrate_estimator/overuse_detector_unittest.cc +++ b/webrtc/modules/remote_bitrate_estimator/overuse_detector_unittest.cc @@ -192,7 +192,7 @@ TEST_F(OveruseDetectorTest, SimpleOveruse2000Kbit30fps) { EXPECT_EQ(0, unique_overuse); int frames_until_overuse = RunUntilOveruse(packets_per_frame, packet_size, frame_duration_ms, sigma_ms, drift_per_frame_ms); - EXPECT_EQ(13, frames_until_overuse); + EXPECT_EQ(8, frames_until_overuse); } TEST_F(OveruseDetectorTest, SimpleOveruse100kbit10fps) { @@ -207,7 +207,7 @@ TEST_F(OveruseDetectorTest, SimpleOveruse100kbit10fps) { EXPECT_EQ(0, unique_overuse); int frames_until_overuse = RunUntilOveruse(packets_per_frame, packet_size, frame_duration_ms, sigma_ms, drift_per_frame_ms); - EXPECT_EQ(11, frames_until_overuse); + EXPECT_EQ(6, frames_until_overuse); } TEST_F(OveruseDetectorTest, DISABLED_OveruseWithHighVariance100Kbit10fps) { @@ -299,7 +299,7 @@ TEST_F(OveruseDetectorTest, OveruseWithLowVariance2000Kbit30fps) { } // Simulate a higher send pace, that is too high. // Total build up of 30 ms. - for (int j = 0; j < 6; ++j) { + for (int j = 0; j < 5; ++j) { UpdateDetector(rtp_timestamp, now_ms_, packet_size); UpdateDetector(rtp_timestamp, now_ms_, packet_size); UpdateDetector(rtp_timestamp, now_ms_, packet_size); @@ -323,10 +323,10 @@ TEST_F(OveruseDetectorTest, int sigma_ms = 3; int unique_overuse = Run100000Samples(packets_per_frame, packet_size, frame_duration_ms, sigma_ms); - EXPECT_EQ(0, unique_overuse); + EXPECT_EQ(13, unique_overuse); int frames_until_overuse = RunUntilOveruse(packets_per_frame, packet_size, frame_duration_ms, sigma_ms, drift_per_frame_ms); - EXPECT_EQ(36, frames_until_overuse); + EXPECT_EQ(14, frames_until_overuse); } TEST_F(OveruseDetectorTest, LowGaussianVarianceFastDrift30Kbit3fps) { @@ -337,7 +337,7 @@ TEST_F(OveruseDetectorTest, LowGaussianVarianceFastDrift30Kbit3fps) { int sigma_ms = 3; int unique_overuse = Run100000Samples(packets_per_frame, packet_size, frame_duration_ms, sigma_ms); - EXPECT_EQ(0, unique_overuse); + EXPECT_EQ(13, unique_overuse); int frames_until_overuse = RunUntilOveruse(packets_per_frame, packet_size, frame_duration_ms, sigma_ms, drift_per_frame_ms); EXPECT_EQ(4, frames_until_overuse); @@ -351,10 +351,10 @@ TEST_F(OveruseDetectorTest, HighGaussianVariance30Kbit3fps) { int sigma_ms = 10; int unique_overuse = Run100000Samples(packets_per_frame, packet_size, frame_duration_ms, sigma_ms); - EXPECT_EQ(0, unique_overuse); + EXPECT_EQ(46, unique_overuse); int frames_until_overuse = RunUntilOveruse(packets_per_frame, packet_size, frame_duration_ms, sigma_ms, drift_per_frame_ms); - EXPECT_EQ(119, frames_until_overuse); + EXPECT_EQ(42, frames_until_overuse); } TEST_F(OveruseDetectorTest, HighGaussianVarianceFastDrift30Kbit3fps) { @@ -365,10 +365,10 @@ TEST_F(OveruseDetectorTest, HighGaussianVarianceFastDrift30Kbit3fps) { int sigma_ms = 10; int unique_overuse = Run100000Samples(packets_per_frame, packet_size, frame_duration_ms, sigma_ms); - EXPECT_EQ(0, unique_overuse); + EXPECT_EQ(46, unique_overuse); int frames_until_overuse = RunUntilOveruse(packets_per_frame, packet_size, frame_duration_ms, sigma_ms, drift_per_frame_ms); - EXPECT_EQ(5, frames_until_overuse); + EXPECT_EQ(4, frames_until_overuse); } TEST_F(OveruseDetectorTest, @@ -380,10 +380,10 @@ TEST_F(OveruseDetectorTest, int sigma_ms = 3; int unique_overuse = Run100000Samples(packets_per_frame, packet_size, frame_duration_ms, sigma_ms); - EXPECT_EQ(0, unique_overuse); + EXPECT_EQ(12, unique_overuse); int frames_until_overuse = RunUntilOveruse(packets_per_frame, packet_size, frame_duration_ms, sigma_ms, drift_per_frame_ms); - EXPECT_EQ(35, frames_until_overuse); + EXPECT_EQ(12, frames_until_overuse); } TEST_F(OveruseDetectorTest, @@ -395,10 +395,10 @@ TEST_F(OveruseDetectorTest, int sigma_ms = 10; int unique_overuse = Run100000Samples(packets_per_frame, packet_size, frame_duration_ms, sigma_ms); - EXPECT_EQ(0, unique_overuse); + EXPECT_EQ(16, unique_overuse); int frames_until_overuse = RunUntilOveruse(packets_per_frame, packet_size, frame_duration_ms, sigma_ms, drift_per_frame_ms); - EXPECT_EQ(115, frames_until_overuse); + EXPECT_EQ(37, frames_until_overuse); } TEST_F(OveruseDetectorTest, @@ -410,10 +410,10 @@ TEST_F(OveruseDetectorTest, int sigma_ms = 3; int unique_overuse = Run100000Samples(packets_per_frame, packet_size, frame_duration_ms, sigma_ms); - EXPECT_EQ(0, unique_overuse); + EXPECT_EQ(12, unique_overuse); int frames_until_overuse = RunUntilOveruse(packets_per_frame, packet_size, frame_duration_ms, sigma_ms, drift_per_frame_ms); - EXPECT_EQ(30, frames_until_overuse); + EXPECT_EQ(12, frames_until_overuse); } TEST_F(OveruseDetectorTest, @@ -425,10 +425,10 @@ TEST_F(OveruseDetectorTest, int sigma_ms = 10; int unique_overuse = Run100000Samples(packets_per_frame, packet_size, frame_duration_ms, sigma_ms); - EXPECT_EQ(0, unique_overuse); + EXPECT_EQ(12, unique_overuse); int frames_until_overuse = RunUntilOveruse(packets_per_frame, packet_size, frame_duration_ms, sigma_ms, drift_per_frame_ms); - EXPECT_EQ(98, frames_until_overuse); + EXPECT_EQ(37, frames_until_overuse); } TEST_F(OveruseDetectorTest, @@ -443,7 +443,7 @@ TEST_F(OveruseDetectorTest, EXPECT_EQ(0, unique_overuse); int frames_until_overuse = RunUntilOveruse(packets_per_frame, packet_size, frame_duration_ms, sigma_ms, drift_per_frame_ms); - EXPECT_EQ(36, frames_until_overuse); + EXPECT_EQ(14, frames_until_overuse); } TEST_F(OveruseDetectorTest, LowGaussianVarianceFastDrift300Kbit30fps) { @@ -457,7 +457,7 @@ TEST_F(OveruseDetectorTest, LowGaussianVarianceFastDrift300Kbit30fps) { EXPECT_EQ(0, unique_overuse); int frames_until_overuse = RunUntilOveruse(packets_per_frame, packet_size, frame_duration_ms, sigma_ms, drift_per_frame_ms); - EXPECT_EQ(8, frames_until_overuse); + EXPECT_EQ(6, frames_until_overuse); } TEST_F(OveruseDetectorTest, HighGaussianVariance300Kbit30fps) { @@ -471,7 +471,7 @@ TEST_F(OveruseDetectorTest, HighGaussianVariance300Kbit30fps) { EXPECT_EQ(0, unique_overuse); int frames_until_overuse = RunUntilOveruse(packets_per_frame, packet_size, frame_duration_ms, sigma_ms, drift_per_frame_ms); - EXPECT_EQ(108, frames_until_overuse); + EXPECT_EQ(49, frames_until_overuse); } TEST_F(OveruseDetectorTest, HighGaussianVarianceFastDrift300Kbit30fps) { @@ -485,7 +485,7 @@ TEST_F(OveruseDetectorTest, HighGaussianVarianceFastDrift300Kbit30fps) { EXPECT_EQ(0, unique_overuse); int frames_until_overuse = RunUntilOveruse(packets_per_frame, packet_size, frame_duration_ms, sigma_ms, drift_per_frame_ms); - EXPECT_EQ(14, frames_until_overuse); + EXPECT_EQ(8, frames_until_overuse); } TEST_F(OveruseDetectorTest, @@ -500,7 +500,7 @@ TEST_F(OveruseDetectorTest, EXPECT_EQ(0, unique_overuse); int frames_until_overuse = RunUntilOveruse(packets_per_frame, packet_size, frame_duration_ms, sigma_ms, drift_per_frame_ms); - EXPECT_EQ(36, frames_until_overuse); + EXPECT_EQ(14, frames_until_overuse); } TEST_F(OveruseDetectorTest, LowGaussianVarianceFastDrift1000Kbit30fps) { @@ -514,7 +514,7 @@ TEST_F(OveruseDetectorTest, LowGaussianVarianceFastDrift1000Kbit30fps) { EXPECT_EQ(0, unique_overuse); int frames_until_overuse = RunUntilOveruse(packets_per_frame, packet_size, frame_duration_ms, sigma_ms, drift_per_frame_ms); - EXPECT_EQ(8, frames_until_overuse); + EXPECT_EQ(6, frames_until_overuse); } TEST_F(OveruseDetectorTest, HighGaussianVariance1000Kbit30fps) { @@ -528,7 +528,7 @@ TEST_F(OveruseDetectorTest, HighGaussianVariance1000Kbit30fps) { EXPECT_EQ(0, unique_overuse); int frames_until_overuse = RunUntilOveruse(packets_per_frame, packet_size, frame_duration_ms, sigma_ms, drift_per_frame_ms); - EXPECT_EQ(108, frames_until_overuse); + EXPECT_EQ(49, frames_until_overuse); } TEST_F(OveruseDetectorTest, HighGaussianVarianceFastDrift1000Kbit30fps) { @@ -542,7 +542,7 @@ TEST_F(OveruseDetectorTest, HighGaussianVarianceFastDrift1000Kbit30fps) { EXPECT_EQ(0, unique_overuse); int frames_until_overuse = RunUntilOveruse(packets_per_frame, packet_size, frame_duration_ms, sigma_ms, drift_per_frame_ms); - EXPECT_EQ(14, frames_until_overuse); + EXPECT_EQ(8, frames_until_overuse); } TEST_F(OveruseDetectorTest, @@ -557,7 +557,7 @@ TEST_F(OveruseDetectorTest, EXPECT_EQ(0, unique_overuse); int frames_until_overuse = RunUntilOveruse(packets_per_frame, packet_size, frame_duration_ms, sigma_ms, drift_per_frame_ms); - EXPECT_EQ(36, frames_until_overuse); + EXPECT_EQ(14, frames_until_overuse); } TEST_F(OveruseDetectorTest, LowGaussianVarianceFastDrift2000Kbit30fps) { @@ -571,7 +571,7 @@ TEST_F(OveruseDetectorTest, LowGaussianVarianceFastDrift2000Kbit30fps) { EXPECT_EQ(0, unique_overuse); int frames_until_overuse = RunUntilOveruse(packets_per_frame, packet_size, frame_duration_ms, sigma_ms, drift_per_frame_ms); - EXPECT_EQ(8, frames_until_overuse); + EXPECT_EQ(6, frames_until_overuse); } TEST_F(OveruseDetectorTest, HighGaussianVariance2000Kbit30fps) { @@ -585,7 +585,7 @@ TEST_F(OveruseDetectorTest, HighGaussianVariance2000Kbit30fps) { EXPECT_EQ(0, unique_overuse); int frames_until_overuse = RunUntilOveruse(packets_per_frame, packet_size, frame_duration_ms, sigma_ms, drift_per_frame_ms); - EXPECT_EQ(108, frames_until_overuse); + EXPECT_EQ(49, frames_until_overuse); } TEST_F(OveruseDetectorTest, HighGaussianVarianceFastDrift2000Kbit30fps) { @@ -599,7 +599,7 @@ TEST_F(OveruseDetectorTest, HighGaussianVarianceFastDrift2000Kbit30fps) { EXPECT_EQ(0, unique_overuse); int frames_until_overuse = RunUntilOveruse(packets_per_frame, packet_size, frame_duration_ms, sigma_ms, drift_per_frame_ms); - EXPECT_EQ(14, frames_until_overuse); + EXPECT_EQ(8, frames_until_overuse); } class OveruseDetectorExperimentTest : public OveruseDetectorTest { diff --git a/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_unittest_helper.cc b/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_unittest_helper.cc index de9873a13b..315f5422d9 100644 --- a/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_unittest_helper.cc +++ b/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_unittest_helper.cc @@ -473,7 +473,7 @@ void RemoteBitrateEstimatorTest::CapacityDropTestHelper( kMinExpectedBitrate, kMaxExpectedBitrate, kInitialCapacityBps); - EXPECT_NEAR(kInitialCapacityBps, bitrate_bps, 100000u); + EXPECT_NEAR(kInitialCapacityBps, bitrate_bps, 110000u); bitrate_observer_->Reset(); // Reduce the capacity and verify the decrease time.