zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use source_sets in component builds and static_library in release builds.

Browse Source 
Static libraries don't guarantee that an exported symbol gets linked
into a shared library (and in order to support Chromium's component
build mode, WebRTC needs to be linked as a shared library).

Source sets always pass all the object files to the linker.

On the flip side, source_sets link more object files in release builds
and to avoid this, this CL introduces a the GN template "rtc_library" that
expands to static_library during release builds and to source_set during
component builds.

See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set

Bug: webrtc:9419
Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#29525}
This commit is contained in:
Mirko Bonadei
2019-10-17 21:32:04 +02:00
committed by Commit Bot
parent e8b962bd3c
commit 86d053c2db
100 changed files with 756 additions and 654 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
modules/video_processing/BUILD.gn
View File

@ -10,7 +10,7 @@ import("../../webrtc.gni")
build_video_processing_sse2 = current_cpu == "x86" || current_cpu == "x64"
rtc_static_library("video_processing") {
rtc_library("video_processing") {
visibility = [ "*" ]
sources = [
"util/denoiser_filter.cc",
@ -60,7 +60,7 @@ rtc_source_set("denoiser_filter") {
}
if (build_video_processing_sse2) {
rtc_static_library("video_processing_sse2") {
rtc_library("video_processing_sse2") {
sources = [
"util/denoiser_filter_sse2.cc",
"util/denoiser_filter_sse2.h",
@ -79,7 +79,7 @@ if (build_video_processing_sse2) {
}
if (rtc_build_with_neon) {
rtc_static_library("video_processing_neon") {
rtc_library("video_processing_neon") {
sources = [
"util/denoiser_filter_neon.cc",
"util/denoiser_filter_neon.h",
@ -97,7 +97,7 @@ if (rtc_build_with_neon) {
}
if (rtc_include_tests) {
rtc_source_set("video_processing_unittests") {
rtc_library("video_processing_unittests") {
testonly = true
sources = [