zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove internal media/base/ stringstream usages

Browse Source 
The %f -> %g changes are there to make the SimpleStringBuilder behave like stringstream/cout and friends. With %f it prints e.g. 2.2 as 2.200000. This change also makes it use scientific notation for numbers > 1000000, like the other streams.

Bug: webrtc:8982
Change-Id: Id174b02c5776460607f48efc196a08673b67eeb0
Reviewed-on: https://webrtc-review.googlesource.com/67080
Commit-Queue: Jonas Olsson <jonasolsson@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23094}
This commit is contained in:
Jonas Olsson
2018-05-03 11:45:33 +02:00
committed by Commit Bot
parent d8b4f1eb24
commit 88c99562b6
5 changed files with 54 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
rtc_base/strings/string_builder.cc
View File

@ -67,15 +67,15 @@ SimpleStringBuilder& SimpleStringBuilder::operator<<(
}
SimpleStringBuilder& SimpleStringBuilder::operator<<(float f) {
return AppendFormat("%f", f);
return AppendFormat("%g", f);
}
SimpleStringBuilder& SimpleStringBuilder::operator<<(double f) {
return AppendFormat("%f", f);
return AppendFormat("%g", f);
}
SimpleStringBuilder& SimpleStringBuilder::operator<<(long double f) {
return AppendFormat("%Lf", f);
return AppendFormat("%Lg", f);
}
SimpleStringBuilder& SimpleStringBuilder::AppendFormat(const char* fmt, ...) {

2
rtc_base/strings/string_builder_unittest.cc
View File

@ -33,7 +33,7 @@ TEST(SimpleStringBuilder, NumbersAndChars) {
SimpleStringBuilder sb(sb_buf);
sb << 1 << ':' << 2.1 << ":" << 2.2f << ':' << 78187493520ll << ':'
<< 78187493520ul;
EXPECT_EQ(0, strcmp(sb.str(), "1:2.100000:2.200000:78187493520:78187493520"));
EXPECT_EQ(0, strcmp(sb.str(), "1:2.1:2.2:78187493520:78187493520"));
}
TEST(SimpleStringBuilder, Format) {