zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't reset bitrate when allocatable minimum changes.

Browse Source 
This fixes an issue where the time between freezes dropped in
perf tests. This was triggered by resetting and updating the bitrates
immediately if the min allocatable bitrate changed, causing a drop in
target bitrate. With this CL, the change in min bitrate will not take
effect until we get more data.

Bug: chromium:940349
Change-Id: Ia680a5f1cfe71847ef90669987e7b89b240b9524
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126625
Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org>
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27054}
This commit is contained in:
Sebastian Jansson
2019-03-11 10:24:51 +01:00
committed by Commit Bot
parent effdfe2014
commit 8a0c1f58cc
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
modules/congestion_controller/goog_cc/goog_cc_network_control.cc
View File

@ -287,10 +287,8 @@ NetworkControlUpdate GoogCcNetworkController::OnStreamsConfig(
if (use_min_allocatable_as_lower_bound_) { if (use_min_allocatable_as_lower_bound_) {
ClampConstraints(); ClampConstraints();
bandwidth_estimation_->SetBitrates(starting_rate_, min_data_rate_,
max_data_rate_, msg.at_time);
delay_based_bwe_->SetMinBitrate(min_data_rate_); delay_based_bwe_->SetMinBitrate(min_data_rate_);
MaybeTriggerOnNetworkChanged(&update, msg.at_time); bandwidth_estimation_->SetMinMaxBitrate(min_data_rate_, max_data_rate_);
} }
} }
if (msg.max_padding_rate && *msg.max_padding_rate != max_padding_rate_) { if (msg.max_padding_rate && *msg.max_padding_rate != max_padding_rate_) {