zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Clean up PlatformThread.

Browse Source 
* Move PlatformThread to rtc::.
* Remove ::CreateThread factory method.
* Make non-scoped_ptr from a lot of invocations.
* Make Start/Stop void.
* Remove rtc::Thread priorities, which were unused and would collide.
* Add ::IsRunning() to PlatformThread.

BUG=
R=tommi@webrtc.org

Review URL: https://codereview.webrtc.org/1476453002 .

Cr-Commit-Position: refs/heads/master@{#10812}
This commit is contained in:
Peter Boström
2015-11-26 17:45:47 +01:00
parent ad113e50d2
commit 8c38e8b9b9
74 changed files with 374 additions and 1052 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
webrtc/system_wrappers/source/condition_variable_unittest.cc
View File

@ -144,12 +144,10 @@ bool WaitingRunFunction(void* obj) {
class CondVarTest : public ::testing::Test {
public:
CondVarTest() {}
CondVarTest() : thread_(&WaitingRunFunction, &baton_, "CondVarTest") {}
virtual void SetUp() {
thread_ = PlatformThread::CreateThread(&WaitingRunFunction, &baton_,
"CondVarTest");
ASSERT_TRUE(thread_->Start());
thread_.Start();
}
virtual void TearDown() {
@ -160,14 +158,14 @@ class CondVarTest : public ::testing::Test {
// and Pass).
ASSERT_TRUE(baton_.Pass(kShortWaitMs));
ASSERT_TRUE(baton_.Grab(kShortWaitMs));
ASSERT_TRUE(thread_->Stop());
thread_.Stop();
}
protected:
Baton baton_;
private:
rtc::scoped_ptr<PlatformThread> thread_;
rtc::PlatformThread thread_;
};
// The SetUp and TearDown functions use condition variables.