zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix several UBsan issues with memcpy

Browse Source 
Most of the changes are trivial.

Bug: webrtc:14432
Change-Id: I0444527bf57c72c8d65f69754b4a4a1c1d7b2e92
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/275340
Reviewed-by: Erik Språng <sprang@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Victor Boivie <boivie@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38074}
This commit is contained in:
Byoungchan Lee
2022-09-13 17:53:49 +09:00
committed by WebRTC LUCI CQ
parent a0adeb7059
commit 8c725f368c
6 changed files with 23 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
modules/rtp_rtcp/source/rtcp_packet/app.cc
View File

@ -91,7 +91,9 @@ bool App::Create(uint8_t* packet,
ByteWriter<uint32_t>::WriteBigEndian(&packet[*index + 0], sender_ssrc());
ByteWriter<uint32_t>::WriteBigEndian(&packet[*index + 4], name_);
memcpy(&packet[*index + 8], data_.data(), data_.size());
if (!data_.empty()) {
memcpy(&packet[*index + 8], data_.data(), data_.size());
}
*index += (8 + data_.size());
RTC_DCHECK_EQ(index_end, *index);
return true;