zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Update URI of TransportSequenceNumberV2

Browse Source 
The previous URI was a placeholder and is not valid. The URI
https://webrtc.org/experiments/rtp-hdrext/transport-wide-cc-02/
must be used instead.

Bug: webrtc:10264
Change-Id: Ibabde599b5bbd116c1c5e86ba0c9c64019bf7026
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126360
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Johannes Kron <kron@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27051}
This commit is contained in:
Johannes Kron
2019-03-07 22:36:35 +01:00
committed by Commit Bot
parent aba8dc2a00
commit 8cc711a7e1
4 changed files with 9 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
api/rtp_parameters.cc
View File

@ -105,7 +105,7 @@ const char RtpExtension::kVideoRotationUri[] = "urn:3gpp:video-orientation";
const char RtpExtension::kTransportSequenceNumberUri[] =
"http://www.ietf.org/id/draft-holmer-rmcat-transport-wide-cc-extensions-01";
const char RtpExtension::kTransportSequenceNumberV2Uri[] =
"http://www.ietf.org/id/draft-holmer-rmcat-transport-wide-cc-extensions-02";
"http://www.webrtc.org/experiments/rtp-hdrext/transport-wide-cc-02";
// This extension allows applications to adaptively limit the playout delay
// on frames as per the current needs. For example, a gaming application

3
modules/rtp_rtcp/source/rtp_header_extensions.h
View File

@ -97,8 +97,7 @@ class TransportSequenceNumberV2 {
static constexpr uint8_t kValueSizeBytes = 4;
static constexpr uint8_t kValueSizeBytesWithoutFeedbackRequest = 2;
static constexpr const char kUri[] =
"http://www.ietf.org/id/"
"draft-holmer-rmcat-transport-wide-cc-extensions-02";
"http://www.webrtc.org/experiments/rtp-hdrext/transport-wide-cc-02";
static bool Parse(rtc::ArrayView<const uint8_t> data,
uint16_t* transport_sequence_number,
absl::optional<FeedbackRequest>* feedback_request);

2
pc/media_session.cc
View File

@ -1113,7 +1113,7 @@ static void NegotiateRtpHeaderExtensions(
// Don't respond to
// http://www.ietf.org/id/draft-holmer-rmcat-transport-wide-cc-extensions-01
// if we get an offer including
// http://www.ietf.org/id/draft-holmer-rmcat-transport-wide-cc-extensions-02
// http://www.webrtc.org/experiments/rtp-hdrext/transport-wide-cc-02
continue;
} else {
// We respond with their RTP header extension id.

8
pc/media_session_unittest.cc
View File

@ -223,14 +223,14 @@ static const RtpExtension kRtpExtensionTransportSequenceNumber01And02[] = {
RtpExtension("http://www.ietf.org/id/"
"draft-holmer-rmcat-transport-wide-cc-extensions-01",
1),
RtpExtension("http://www.ietf.org/id/"
"draft-holmer-rmcat-transport-wide-cc-extensions-02",
RtpExtension(
"http://www.webrtc.org/experiments/rtp-hdrext/transport-wide-cc-02",
2),
};
static const RtpExtension kRtpExtensionTransportSequenceNumber02[] = {
RtpExtension("http://www.ietf.org/id/"
"draft-holmer-rmcat-transport-wide-cc-extensions-02",
RtpExtension(
"http://www.webrtc.org/experiments/rtp-hdrext/transport-wide-cc-02",
2),
};