zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Deprecated BitrateController::CreateRtcpBandwidthObserver.

Browse Source 
The RtcpBandwidthObserverImpl did not provide any features that a raw pointer does not have. deprecating it to simplify further refactoring down the line. Preferring raw pointer usage as it provides equivalent functionality in less code.


Bug: webrtc:8415
Change-Id: Id2c4c73a331835f124da8d308615ca2ce34b2d1b
Reviewed-on: https://webrtc-review.googlesource.com/22500
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20712}
This commit is contained in:
Sebastian Jansson
2017-11-15 17:22:16 +01:00
committed by Commit Bot
parent 90657302be
commit 8d9c5406c7
13 changed files with 35 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
modules/bitrate_controller/include/bitrate_controller.h
View File

@ -69,8 +69,10 @@ class BitrateController : public Module, public RtcpBandwidthObserver {
virtual ~BitrateController() {}
// Deprecated, use raw pointer to BitrateController instance instead.
// Creates RtcpBandwidthObserver caller responsible to delete.
virtual RtcpBandwidthObserver* CreateRtcpBandwidthObserver() = 0;
RTC_DEPRECATED virtual RtcpBandwidthObserver*
CreateRtcpBandwidthObserver() = 0;
// Deprecated
virtual void SetStartBitrate(int start_bitrate_bps) = 0;