zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make lint errors fatal in presubmit and fix files in whitelisted paths

Browse Source 
BUG=webrtc:5149

Review-Url: https://codereview.webrtc.org/2762963002
Cr-Commit-Position: refs/heads/master@{#17323}
This commit is contained in:
oprypin
2017-03-21 07:52:41 -07:00
committed by Commit bot
parent 92e448d529
commit 8e58d65ddf
6 changed files with 11 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
PRESUBMIT.py
View File

@ -255,9 +255,7 @@ def _CheckApprovedFilesLintClean(input_api, output_api,
if cpplint._cpplint_state.error_count > 0:
if input_api.is_committing:
# TODO(kjellander): Change back to PresubmitError below when we're
# confident with the lint settings.
res_type = output_api.PresubmitPromptWarning
res_type = output_api.PresubmitError
else:
res_type = output_api.PresubmitPromptWarning
result = [res_type('Changelist failed cpplint.py check.')]