zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Enable GetRemoteAudioSSLCertificate tests for Unified Plan

Browse Source 
They were disabled since GetRemoteAudioSSLCertificate was written
in terms of voice/video channel, which were not methods supported
with Unified Plan. Now GetRemoteAudioSSLCertificate has been
rewritten to work with RtpTransceivers, so the test can be enabled.

Bug: webrtc:8764
Change-Id: I08b5fbcc0d69f36113a281c902db6508fa48ebdd
Reviewed-on: https://webrtc-review.googlesource.com/55923
Reviewed-by: Seth Hampson <shampson@webrtc.org>
Commit-Queue: Steve Anton <steveanton@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22115}
This commit is contained in:
Steve Anton
2018-02-20 17:19:19 -08:00
committed by Commit Bot
parent 6e22137f70
commit 8ee1e5e6e6
1 changed files with 0 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
pc/peerconnection_integrationtest.cc
View File

@ -1591,10 +1591,6 @@ TEST_P(PeerConnectionIntegrationTest, EndToEndCallWithSdes) {
// certificate once the DTLS handshake has finished. // certificate once the DTLS handshake has finished.
TEST_P(PeerConnectionIntegrationTest, TEST_P(PeerConnectionIntegrationTest,
GetRemoteAudioSSLCertificateReturnsExchangedCertificate) { GetRemoteAudioSSLCertificateReturnsExchangedCertificate) {
// TODO(bugs.webrtc.org/8764): Enable for Unified Plan once stats work.
if (sdp_semantics_ == SdpSemantics::kUnifiedPlan) {
return;
}
auto GetRemoteAudioSSLCertificate = [](PeerConnectionWrapper* wrapper) { auto GetRemoteAudioSSLCertificate = [](PeerConnectionWrapper* wrapper) {
auto pci = reinterpret_cast<PeerConnectionProxy*>(wrapper->pc()); auto pci = reinterpret_cast<PeerConnectionProxy*>(wrapper->pc());
auto pc = reinterpret_cast<PeerConnection*>(pci->internal()); auto pc = reinterpret_cast<PeerConnection*>(pci->internal());