zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

New PeerConnectionInterface::GetStats: No bogus default implementation.

Browse Source 
The Chromium mock implementation implements the new GetStats API, so we
can remove this default implementation.

BUG=chromium:627816

Review-Url: https://codereview.webrtc.org/2566143002
Cr-Commit-Position: refs/heads/master@{#15563}
This commit is contained in:
hbos
2016-12-13 01:45:09 -08:00
committed by Commit bot
parent 03392d0047
commit 8f2309478d
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
webrtc/api/peerconnectioninterface.h
View File

@ -474,10 +474,8 @@ class PeerConnectionInterface : public rtc::RefCountInterface {
StatsOutputLevel level) = 0;
// Gets stats using the new stats collection API, see webrtc/api/stats/. These
// will replace old stats collection API when the new API has matured enough.
// TODO(hbos): Default implementation that does nothing only exists as to not
// break third party projects. As soon as they have been updated this should
// be changed to "= 0;".
virtual void GetStats(RTCStatsCollectorCallback* callback) {}
// Master bug: crbug.com/627816
virtual void GetStats(RTCStatsCollectorCallback* callback) = 0;
virtual rtc::scoped_refptr<DataChannelInterface> CreateDataChannel(
const std::string& label,