Extract bitrate allocation of spatial/temporal layers out of codec impl.
This CL makes a number of intervowen changes: * Add BitrateAllocation struct, that contains a codec independent view of how the target bitrate is distributed over spatial and temporal layers. * Adds the BitrateAllocator interface, which takes a bitrate and frame rate and produces a BitrateAllocation. * A default (non layered) implementation is added, and SimulcastRateAllocator is extended to fully handle VP8 allocation. This includes capturing TemporalLayer instances created by the encoder. * ViEEncoder now owns both the bitrate allocator and the temporal layer factories for VP8. This allows allocation to happen fully outside of the encoder implementation. This refactoring will make it possible for ViEEncoder to signal the full picture of target bitrates to the RTCP module. BUG=webrtc:6301 Review-Url: https://codereview.webrtc.org/2434073003 Cr-Commit-Position: refs/heads/master@{#14998}
This commit is contained in:
@ -112,7 +112,8 @@ class MediaCodecVideoEncoder : public webrtc::VideoEncoder,
|
||||
int32_t Release() override;
|
||||
int32_t SetChannelParameters(uint32_t /* packet_loss */,
|
||||
int64_t /* rtt */) override;
|
||||
int32_t SetRates(uint32_t new_bit_rate, uint32_t frame_rate) override;
|
||||
int32_t SetRateAllocation(const webrtc::BitrateAllocation& rate_allocation,
|
||||
uint32_t frame_rate) override;
|
||||
|
||||
// rtc::MessageHandler implementation.
|
||||
void OnMessage(rtc::Message* msg) override;
|
||||
@ -465,11 +466,12 @@ int32_t MediaCodecVideoEncoder::SetChannelParameters(uint32_t /* packet_loss */,
|
||||
return WEBRTC_VIDEO_CODEC_OK;
|
||||
}
|
||||
|
||||
int32_t MediaCodecVideoEncoder::SetRates(uint32_t new_bit_rate,
|
||||
uint32_t frame_rate) {
|
||||
int32_t MediaCodecVideoEncoder::SetRateAllocation(
|
||||
const webrtc::BitrateAllocation& rate_allocation,
|
||||
uint32_t frame_rate) {
|
||||
return codec_thread_->Invoke<int32_t>(
|
||||
RTC_FROM_HERE, Bind(&MediaCodecVideoEncoder::SetRatesOnCodecThread, this,
|
||||
new_bit_rate, frame_rate));
|
||||
rate_allocation.get_sum_kbps(), frame_rate));
|
||||
}
|
||||
|
||||
void MediaCodecVideoEncoder::OnMessage(rtc::Message* msg) {
|
||||
|
||||
Reference in New Issue
Block a user