Style fixes in rtcp_packet/

1. To make the files conform to chromium-style guidelines, and stop the compiler from complaing:
1.1. Move constructors out of .h file.
1.2. Move destructors out of .h file.
1.3. Move virtual functions out of .h file.
2. BlockLength() and Create() did not have consistent access modifiers in the various subclasses of RtcpPacket. Change the access level to public throughout.
3. Reorder BlockLength() and Create() where necessary, to reflect the order defined in the parent class (RtcpPacket).

BUG=None

Review-Url: https://codereview.webrtc.org/2937403002
Cr-Commit-Position: refs/heads/master@{#18633}
This commit is contained in:
eladalon
2017-06-16 07:07:47 -07:00
committed by Commit Bot
parent 6b826ef66d
commit 8fa21c49ef
36 changed files with 179 additions and 119 deletions

View File

@ -40,9 +40,8 @@ class Sdes : public RtcpPacket {
const std::vector<Chunk>& chunks() const { return chunks_; }
size_t BlockLength() const override { return block_length_; }
size_t BlockLength() const override;
protected:
bool Create(uint8_t* packet,
size_t* index,
size_t max_length,