zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix comment typo about degradation preference.

Browse Source 
Switched comments for MAINTAIN_FRAMERATE and MAINTAIN_RESOLUTION.

Bug: none
Change-Id: Ibad00978c5096112a119e5e76d40b11752334594
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/139109
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Commit-Queue: Åsa Persson <asapersson@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28148}
This commit is contained in:
Åsa Persson
2019-05-31 13:29:35 +02:00
committed by Commit Bot
parent bd002715a8
commit 90bc1e1bad
1 changed files with 12 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
api/rtp_parameters.h
View File

@ -80,9 +80,9 @@ enum class DegradationPreference {
// Don't take any actions based on over-utilization signals. Not part of the
// web API.
DISABLED,
// On over-use, request lower frame rate, possibly causing frame drops.
MAINTAIN_FRAMERATE,
// On over-use, request lower resolution, possibly causing down-scaling.
MAINTAIN_FRAMERATE,
// On over-use, request lower frame rate, possibly causing frame drops.
MAINTAIN_RESOLUTION,
// Try to strike a "pleasing" balance between frame rate or resolution.
BALANCED,
@ -139,8 +139,7 @@ struct RtpCodecCapability {
// TODO(deadbeef): Not implemented.
absl::optional<int> max_ptime;
// Preferred packetization time for an RtpReceiver or RtpSender of this
// codec.
// Preferred packetization time for an RtpReceiver or RtpSender of this codec.
// TODO(deadbeef): Not implemented.
absl::optional<int> ptime;
@ -155,8 +154,8 @@ struct RtpCodecCapability {
// Corresponds to "a=fmtp" parameters in SDP.
//
// Contrary to ORTC, these parameters are named using all lowercase strings.
// This helps make the mapping to SDP simpler, if an application is using
// SDP. Boolean values are represented by the string "1".
// This helps make the mapping to SDP simpler, if an application is using SDP.
// Boolean values are represented by the string "1".
std::unordered_map<std::string, std::string> parameters;
// Codec-specific parameters that may optionally be signaled to the remote
@ -174,9 +173,9 @@ struct RtpCodecCapability {
// TODO(deadbeef): Not implemented.
int max_spatial_layer_extensions = 0;
// Whether the implementation can send/receive SVC layers with distinct
// SSRCs. Always false for audio codecs. True for video codecs that support
// scalable video coding with MRST.
// Whether the implementation can send/receive SVC layers with distinct SSRCs.
// Always false for audio codecs. True for video codecs that support scalable
// video coding with MRST.
// TODO(deadbeef): Not implemented.
bool svc_multi_stream_support = false;
@ -546,8 +545,8 @@ struct RtpCodecParameters {
// Corresponds to "a=fmtp" parameters in SDP.
//
// Contrary to ORTC, these parameters are named using all lowercase strings.
// This helps make the mapping to SDP simpler, if an application is using
// SDP. Boolean values are represented by the string "1".
// This helps make the mapping to SDP simpler, if an application is using SDP.
// Boolean values are represented by the string "1".
std::unordered_map<std::string, std::string> parameters;
bool operator==(const RtpCodecParameters& o) const {
@ -559,9 +558,8 @@ struct RtpCodecParameters {
bool operator!=(const RtpCodecParameters& o) const { return !(*this == o); }
};
// RtpCapabilities is used to represent the static capabilities of an
// endpoint. An application can use these capabilities to construct an
// RtpParameters.
// RtpCapabilities is used to represent the static capabilities of an endpoint.
// An application can use these capabilities to construct an RtpParameters.
struct RTC_EXPORT RtpCapabilities {
RtpCapabilities();
~RtpCapabilities();