zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use backticks not vertical bars to denote variables in comments for /modules/rtp_rtcp

Browse Source 
Bug: webrtc:12338
Change-Id: I52eb3b6675c4705e22f51b70799ed6139a3b46bc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227164
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#34686}
This commit is contained in:
Artem Titov
2021-07-28 23:57:33 +02:00
committed by WebRTC LUCI CQ
parent 7f9ab1aa1b
commit 913cfa76ec
72 changed files with 257 additions and 257 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
modules/rtp_rtcp/source/rtcp_packet/loss_notification.cc
View File

@ -63,7 +63,7 @@ bool LossNotification::Create(uint8_t* packet,
const size_t index_end = *index + BlockLength();
// Note: |index| updated by the function below.
// Note: `index` updated by the function below.
CreateHeader(Psfb::kAfbMessageType, kPacketType, HeaderLength(), packet,
index);

4
modules/rtp_rtcp/source/rtcp_packet/loss_notification.h
View File

@ -42,8 +42,8 @@ class LossNotification : public Psfb {
// Set all of the values transmitted by the loss notification message.
// If the values may not be represented by a loss notification message,
// false is returned, and no change is made to the object; this happens
// when |last_recieved| is ahead of |last_decoded| by more than 0x7fff.
// This is because |last_recieved| is represented on the wire as a delta,
// when `last_recieved` is ahead of `last_decoded` by more than 0x7fff.
// This is because `last_recieved` is represented on the wire as a delta,
// and only 15 bits are available for that delta.
ABSL_MUST_USE_RESULT
bool Set(uint16_t last_decoded,

2
modules/rtp_rtcp/source/rtcp_packet/loss_notification_unittest.cc
View File

@ -80,7 +80,7 @@ TEST(RtcpPacketLossNotificationTest,
test::ParseSinglePacket(packet, packet_length_bytes, &loss_notification));
// Show that after shaving off a word, the packet is no longer parsable.
packet[3] -= 1; // Change the |length| field of the RTCP packet.
packet[3] -= 1; // Change the `length` field of the RTCP packet.
packet_length_bytes -= 4; // Effectively forget the last 32-bit word.
EXPECT_FALSE(
test::ParseSinglePacket(packet, packet_length_bytes, &loss_notification));

6
modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc
View File

@ -129,7 +129,7 @@ uint16_t TransportFeedback::LastChunk::Emit() {
}
RTC_DCHECK_GE(size_, kMaxTwoBitCapacity);
uint16_t chunk = EncodeTwoBit(kMaxTwoBitCapacity);
// Remove |kMaxTwoBitCapacity| encoded delta sizes:
// Remove `kMaxTwoBitCapacity` encoded delta sizes:
// Shift remaining delta sizes and recalculate all_same_ && has_large_delta_.
size_ -= kMaxTwoBitCapacity;
all_same_ = true;
@ -153,7 +153,7 @@ uint16_t TransportFeedback::LastChunk::EncodeLast() const {
return EncodeOneBit();
}
// Appends content of the Lastchunk to |deltas|.
// Appends content of the Lastchunk to `deltas`.
void TransportFeedback::LastChunk::AppendTo(
std::vector<DeltaSize>* deltas) const {
if (all_same_) {
@ -441,7 +441,7 @@ bool TransportFeedback::Parse(const CommonHeader& packet) {
last_chunk_.Decode(chunk, status_count - delta_sizes.size());
last_chunk_.AppendTo(&delta_sizes);
}
// Last chunk is stored in the |last_chunk_|.
// Last chunk is stored in the `last_chunk_`.
encoded_chunks_.pop_back();
RTC_DCHECK_EQ(delta_sizes.size(), status_count);
num_seq_no_ = status_count;

12
modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h
View File

@ -54,7 +54,7 @@ class TransportFeedback : public Rtpfb {
TransportFeedback();
// If |include_timestamps| is set to false, the created packet will not
// If `include_timestamps` is set to false, the created packet will not
// contain the receive delta block.
explicit TransportFeedback(bool include_timestamps,
bool include_lost = false);
@ -80,7 +80,7 @@ class TransportFeedback : public Rtpfb {
int64_t GetBaseTimeUs() const;
TimeDelta GetBaseTime() const;
// Get the unwrapped delta between current base time and |prev_timestamp_us|.
// Get the unwrapped delta between current base time and `prev_timestamp_us`.
int64_t GetBaseDeltaUs(int64_t prev_timestamp_us) const;
TimeDelta GetBaseDelta(TimeDelta prev_timestamp) const;
@ -116,9 +116,9 @@ class TransportFeedback : public Rtpfb {
bool Empty() const;
void Clear();
// Return if delta sizes still can be encoded into single chunk with added
// |delta_size|.
// `delta_size`.
bool CanAdd(DeltaSize delta_size) const;
// Add |delta_size|, assumes |CanAdd(delta_size)|,
// Add `delta_size`, assumes `CanAdd(delta_size)`,
void Add(DeltaSize delta_size);
// Encode chunk as large as possible removing encoded delta sizes.
@ -127,9 +127,9 @@ class TransportFeedback : public Rtpfb {
// Encode all stored delta_sizes into single chunk, pad with 0s if needed.
uint16_t EncodeLast() const;
// Decode up to |max_size| delta sizes from |chunk|.
// Decode up to `max_size` delta sizes from `chunk`.
void Decode(uint16_t chunk, size_t max_size);
// Appends content of the Lastchunk to |deltas|.
// Appends content of the Lastchunk to `deltas`.
void AppendTo(std::vector<DeltaSize>* deltas) const;
private: