zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Enable and fix chromium clang warnings in rtp_rtcp test targets

Browse Source 
Bug: webrtc:163
Change-Id: I4ed3e63296d8bf06536a83196d597c7a906ba11c
Reviewed-on: https://webrtc-review.googlesource.com/60802
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22357}
This commit is contained in:
Danil Chapovalov
2018-03-08 14:09:06 +01:00
committed by Commit Bot
parent 7bb37b884b
commit 9486b117da
32 changed files with 184 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
modules/rtp_rtcp/test/testAPI/test_api_rtcp.cc
View File

@ -35,7 +35,7 @@ class RtcpCallback : public RtcpIntraFrameObserver {
}
virtual void OnLipSyncUpdate(const int32_t id,
const int32_t audioVideoOffset) {}
virtual void OnReceivedIntraFrameRequest(uint32_t ssrc) {}
void OnReceivedIntraFrameRequest(uint32_t ssrc) override {}
private:
RtpRtcp* _rtpRtcpModule;
@ -44,7 +44,7 @@ class RtcpCallback : public RtcpIntraFrameObserver {
class TestRtpFeedback : public NullRtpFeedback {
public:
explicit TestRtpFeedback(RtpRtcp* rtp_rtcp) : rtp_rtcp_(rtp_rtcp) {}
virtual ~TestRtpFeedback() {}
~TestRtpFeedback() override = default;
void OnIncomingSSRCChanged(uint32_t ssrc) override {
rtp_rtcp_->SetRemoteSSRC(ssrc);
@ -64,9 +64,9 @@ class RtpRtcpRtcpTest : public ::testing::Test {
test_timestamp = 4567;
test_sequence_number = 2345;
}
~RtpRtcpRtcpTest() {}
~RtpRtcpRtcpTest() override = default;
virtual void SetUp() {
void SetUp() override {
receiver = new TestRtpReceiver();
transport1 = new LoopBackTransport();
transport2 = new LoopBackTransport();
@ -149,7 +149,7 @@ class RtpRtcpRtcpTest : public ::testing::Test {
test, 8, nullptr, nullptr, nullptr));
}
virtual void TearDown() {
void TearDown() override {
delete module1;
delete module2;
delete myRTCPFeedback1;