zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Enable clang::find_bad_constructs for examples/androidnativeapi.

Browse Source 
This CL removes //build/config/clang:find_bad_constructs from the
suppressed_configs list, which means that clang:find_bad_constructs
is now enabled on these translation units.

Bug: webrtc:9251, webrtc:163
Change-Id: I9f3c3ce78aa82cbf68f34999b0a7fa9507fe5154
Reviewed-on: https://webrtc-review.googlesource.com/89741
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24059}
This commit is contained in:
Mirko Bonadei
2018-07-20 13:33:06 +02:00
committed by Commit Bot
parent 0c3ad73948
commit 94ef424b31
3 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
examples/androidnativeapi/BUILD.gn
View File

@ -43,11 +43,6 @@ rtc_shared_library("examples_androidnativeapi_jni") {
suppressed_configs += [ "//build/config/android:hide_all_but_jni_onload" ] suppressed_configs += [ "//build/config/android:hide_all_but_jni_onload" ]
configs += [ "//build/config/android:hide_all_but_jni" ] configs += [ "//build/config/android:hide_all_but_jni" ]
if (is_clang) {
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
}
deps = [ deps = [
":generated_jni", ":generated_jni",
"//api:libjingle_peerconnection_api", "//api:libjingle_peerconnection_api",

2
examples/androidnativeapi/jni/androidcallclient.cc
View File

@ -80,6 +80,8 @@ AndroidCallClient::AndroidCallClient()
CreatePeerConnectionFactory(); CreatePeerConnectionFactory();
} }
AndroidCallClient::~AndroidCallClient() = default;
void AndroidCallClient::Call(JNIEnv* env, void AndroidCallClient::Call(JNIEnv* env,
const webrtc::JavaRef<jobject>& cls, const webrtc::JavaRef<jobject>& cls,
const webrtc::JavaRef<jobject>& local_sink, const webrtc::JavaRef<jobject>& local_sink,

1
examples/androidnativeapi/jni/androidcallclient.h
View File

@ -28,6 +28,7 @@ namespace webrtc_examples {
class AndroidCallClient { class AndroidCallClient {
public: public:
AndroidCallClient(); AndroidCallClient();
~AndroidCallClient();
void Call(JNIEnv* env, void Call(JNIEnv* env,
const webrtc::JavaRef<jobject>& cls, const webrtc::JavaRef<jobject>& cls,