zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert of PyLint fixes for tools-webrtc and webrtc/tools (patchset #3 id:40001 of https://codereview.webrtc.org/2736233003/ )

Browse Source 
Reason for revert:
Fails video quality tests in Chrome:  http://build.chromium.org/p/chromium.webrtc.fyi/builders/Win10%20Tester/builds/6568
I should have looked more closer at those :(

Original issue's description:
> PyLint fixes for tools-webrtc and webrtc/tools
>
> Fix a lot of errors before bringing in the new config in
> https://codereview.webrtc.org/2737963003/
>
> BUG=webrtc:7303
> NOTRY=True
>
> Review-Url: https://codereview.webrtc.org/2736233003
> Cr-Commit-Position: refs/heads/master@{#17137}
> Committed: f5318e1f39

TBR=oprypin@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:7303

Review-Url: https://codereview.webrtc.org/2737233003
Cr-Commit-Position: refs/heads/master@{#17142}
This commit is contained in:
kjellander
2017-03-09 06:09:33 -08:00
committed by Commit bot
parent 09f3e3e7b4
commit 94f4d9effc
15 changed files with 145 additions and 142 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tools-webrtc/check_package_boundaries_test.py
View File

@ -30,7 +30,7 @@ class Logger(object):
self.messages = []
self.test_dir = test_dir
def Log(self, build_file_path, line_number, target_name, source_file,
def log(self, build_file_path, line_number, target_name, source_file,
subpackage):
build_file_path = os.path.relpath(build_file_path, self.test_dir)
build_file_path = build_file_path.replace(os.path.sep, '/')
@ -48,19 +48,19 @@ class UnitTest(unittest.TestCase):
expected_messages = ReadPylFile(os.path.join(test_dir, 'expected.pyl'))
self.assertListEqual(sorted(expected_messages), sorted(logger.messages))
def testNoErrors(self):
def test_no_errors(self):
self.RunTest(os.path.join(TESTDATA_DIR, 'no_errors'))
def testMultipleErrorsSingleTarget(self):
def test_multiple_errors_single_target(self):
self.RunTest(os.path.join(TESTDATA_DIR, 'multiple_errors_single_target'))
def testMultipleErrorsMultipleTargets(self):
def test_multiple_errors_multiple_targets(self):
self.RunTest(os.path.join(TESTDATA_DIR, 'multiple_errors_multiple_targets'))
def testCommonPrefix(self):
def test_common_prefix(self):
self.RunTest(os.path.join(TESTDATA_DIR, 'common_prefix'))
def testAllBuildFiles(self):
def test_all_build_files(self):
self.RunTest(os.path.join(TESTDATA_DIR, 'all_build_files'), True)