From 956f281d2f1220e51185e06f80eaf1ee54b694fd Mon Sep 17 00:00:00 2001 From: "pbos@webrtc.org" Date: Wed, 27 Aug 2014 18:41:58 +0000 Subject: [PATCH] Re-enable all VideoAdapterTests on DrMemory. These bugs should've been resolved as of r6991. BUG=3655,3671 R=henrike@webrtc.org Review URL: https://webrtc-codereview.appspot.com/22529004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6992 4adac7df-926f-26a2-2b94-8c16560cd09d --- .../valgrind-webrtc/drmemory/suppressions.txt | 62 ------------------- ...le_media_unittest.gtest-drmemory_win32.txt | 4 -- 2 files changed, 66 deletions(-) diff --git a/tools/valgrind-webrtc/drmemory/suppressions.txt b/tools/valgrind-webrtc/drmemory/suppressions.txt index 8f85c3ed76..90831d1a96 100644 --- a/tools/valgrind-webrtc/drmemory/suppressions.txt +++ b/tools/valgrind-webrtc/drmemory/suppressions.txt @@ -119,68 +119,6 @@ system call NtUserGetThreadDesktop parameter value #1 *!webrtc::ScreenCapturerTest::SetUp *!testing::internal::HandleSehExceptionsInMethodIfSupported -# libjingle_media_unittest fails on Win DrMemory Full -UNADDRESSABLE ACCESS -name=https://code.google.com/p/webrtc/issues/detail?id=3655 (1) -*!cricket::VideoFrame::~VideoFrame -*!cricket::VideoFrame::`scalar deleting destructor' -*!rtc::DefaultDeleter<>::operator() -*!rtc::internal::scoped_ptr_impl<>::reset -*!rtc::scoped_ptr<>::reset -*!cricket::VideoAdapterTest::VideoCapturerListener::OnFrameCaptured -*!sigslot::_connection2<>::emit -*!sigslot::signal2<>::operator() -*!cricket::FileVideoCapturer::ReadFrame -*!cricket::FileVideoCapturer::FileReadThread::OnMessage -*!rtc::MessageQueue::Dispatch -*!rtc::Thread::ProcessMessages -*!rtc::Thread::Run -*!cricket::FileVideoCapturer::FileReadThread::Run -*!rtc::Thread::PreRun -KERNEL32.dll!BaseThreadInitThunk - -UNADDRESSABLE ACCESS -name=https://code.google.com/p/webrtc/issues/detail?id=3655 (2) -*!rtc::DefaultDeleter<>::operator() -*!rtc::internal::scoped_ptr_impl<>::reset -*!rtc::scoped_ptr<>::reset -*!cricket::VideoAdapterTest::VideoCapturerListener::OnFrameCaptured -*!sigslot::_connection2<>::emit -*!sigslot::signal2<>::operator() -*!cricket::FileVideoCapturer::ReadFrame -*!cricket::FileVideoCapturer::FileReadThread::OnMessage -*!rtc::MessageQueue::Dispatch -*!rtc::Thread::ProcessMessages -*!rtc::Thread::Run -*!cricket::FileVideoCapturer::FileReadThread::Run -*!rtc::Thread::PreRun -KERNEL32.dll!BaseThreadInitThunk - -INVALID HEAP ARGUMENT -name=https://code.google.com/p/webrtc/issues/detail?id=3655 (3) -drmemorylib.dll!replace_operator_delete -*!cricket::VideoFrame::`scalar deleting destructor' -*!rtc::DefaultDeleter<>::operator() -*!rtc::internal::scoped_ptr_impl<>::reset -*!rtc::scoped_ptr<>::reset -*!cricket::VideoAdapterTest::VideoCapturerListener::OnFrameCaptured -*!sigslot::_connection2<>::emit -*!sigslot::signal2<>::operator() -*!cricket::FileVideoCapturer::ReadFrame -*!cricket::FileVideoCapturer::FileReadThread::OnMessage -*!rtc::MessageQueue::Dispatch -*!rtc::Thread::ProcessMessages -*!rtc::Thread::Run -*!cricket::FileVideoCapturer::FileReadThread::Run -*!rtc::Thread::PreRun -KERNEL32.dll!BaseThreadInitThunk - -UNINITIALIZED READ -name=https://code.google.com/p/webrtc/issues/detail?id=3655 (4) -*!testing::internal::CmpHelperNE<> -*!cricket::VideoAdapterTest_BlackOutput_Test::TestBody -*!testing::internal::HandleSehExceptionsInMethodIfSupported<> - UNINITIALIZED READ name=https://code.google.com/p/webrtc/issues/detail?id=3158 (1) *!_output_l diff --git a/tools/valgrind-webrtc/gtest_exclude/libjingle_media_unittest.gtest-drmemory_win32.txt b/tools/valgrind-webrtc/gtest_exclude/libjingle_media_unittest.gtest-drmemory_win32.txt index a93be4a971..87230f33f6 100644 --- a/tools/valgrind-webrtc/gtest_exclude/libjingle_media_unittest.gtest-drmemory_win32.txt +++ b/tools/valgrind-webrtc/gtest_exclude/libjingle_media_unittest.gtest-drmemory_win32.txt @@ -13,7 +13,3 @@ WebRtcVideoChannel2BaseTest.GetStats #TODO(jiayl): https://code.google.com/p/webrtc/issues/detail?id=3492 SctpDataMediaChannelTest.* - -#https://code.google.com/p/webrtc/issues/detail?id=3655 -VideoAdapterTest.AdaptResolutionNarrow -VideoAdapterTest.AdaptResolutionWide