zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove unused setter for Port::socket_factory()

Browse Source 
Also take the opportunity to declare factory_ const.
(Bug reference is where I noticed the possibility; it is unlikely
to fix the bug.)

Bug: chromium:1205343
Change-Id: I6078f170cf68d94314ee184bdfd2dc6f4ffc1e71
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/217385
Reviewed-by: Tommi <tommi@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#33918}
This commit is contained in:
Harald Alvestrand
2021-05-04 13:03:54 +00:00
committed by WebRTC LUCI CQ
parent cc7a36818f
commit 9582fa47db
2 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
p2p/base/port.cc
View File

@ -137,6 +137,7 @@ Port::Port(rtc::Thread* thread,
tiebreaker_(0), tiebreaker_(0),
shared_socket_(true), shared_socket_(true),
weak_factory_(this) { weak_factory_(this) {
RTC_DCHECK(factory_ != NULL);
Construct(); Construct();
} }

5
p2p/base/port.h
View File

@ -218,9 +218,6 @@ class Port : public PortInterface,
// The factory used to create the sockets of this port. // The factory used to create the sockets of this port.
rtc::PacketSocketFactory* socket_factory() const { return factory_; } rtc::PacketSocketFactory* socket_factory() const { return factory_; }
void set_socket_factory(rtc::PacketSocketFactory* factory) {
factory_ = factory;
}
// For debugging purposes. // For debugging purposes.
const std::string& content_name() const { return content_name_; } const std::string& content_name() const { return content_name_; }
@ -445,7 +442,7 @@ class Port : public PortInterface,
void OnNetworkTypeChanged(const rtc::Network* network); void OnNetworkTypeChanged(const rtc::Network* network);
rtc::Thread* const thread_; rtc::Thread* const thread_;
rtc::PacketSocketFactory* factory_; rtc::PacketSocketFactory* const factory_;
std::string type_; std::string type_;
bool send_retransmit_count_attribute_; bool send_retransmit_count_attribute_;
rtc::Network* network_; rtc::Network* network_;