zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Avoid using GlobalTaskQueueFactory in NetworkEmulationManager

Browse Source 
by using TaskQueueForTest that use Default task queue factory directly

Bug: webrtc:10284
Change-Id: I775911c72851e850a9364714008397cf4d3ab484
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128613
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27217}
This commit is contained in:
Danil Chapovalov
2019-03-21 09:58:30 +01:00
committed by Commit Bot
parent ef1052a134
commit 982b576bca
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
test/scenario/network/BUILD.gn
View File

@ -34,8 +34,8 @@ rtc_source_set("emulated_network") {
"../../../api/units:timestamp", "../../../api/units:timestamp",
"../../../rtc_base:rtc_base", "../../../rtc_base:rtc_base",
"../../../rtc_base:rtc_base_tests_utils", "../../../rtc_base:rtc_base_tests_utils",
"../../../rtc_base:rtc_task_queue",
"../../../rtc_base:safe_minmax", "../../../rtc_base:safe_minmax",
"../../../rtc_base:task_queue_for_test",
"../../../rtc_base/task_utils:repeating_task", "../../../rtc_base/task_utils:repeating_task",
"../../../rtc_base/third_party/sigslot:sigslot", "../../../rtc_base/third_party/sigslot:sigslot",
"../../../system_wrappers:system_wrappers", "../../../system_wrappers:system_wrappers",

4
test/scenario/network/network_emulation_manager.h
View File

@ -21,7 +21,7 @@
#include "api/units/timestamp.h" #include "api/units/timestamp.h"
#include "rtc_base/logging.h" #include "rtc_base/logging.h"
#include "rtc_base/network.h" #include "rtc_base/network.h"
#include "rtc_base/task_queue.h" #include "rtc_base/task_queue_for_test.h"
#include "rtc_base/task_utils/repeating_task.h" #include "rtc_base/task_utils/repeating_task.h"
#include "rtc_base/thread.h" #include "rtc_base/thread.h"
#include "system_wrappers/include/clock.h" #include "system_wrappers/include/clock.h"
@ -90,7 +90,7 @@ class NetworkEmulationManagerImpl : public NetworkEmulationManager {
// Must be the last field, so it will be deleted first, because tasks // Must be the last field, so it will be deleted first, because tasks
// in the TaskQueue can access other fields of the instance of this class. // in the TaskQueue can access other fields of the instance of this class.
rtc::TaskQueue task_queue_; TaskQueueForTest task_queue_;
}; };
} // namespace test } // namespace test