Don't link with audio codecs that we don't use
We used to link with all audio codecs unconditionally (except Opus); this patch makes gyp and gn only link to the ones that are used. This unfortunately fails to have a measurable impact on Chromium binary size, at least on x86_64 Linux; it turns out that iLBC and iSAC fix were already being excluded from Chromium by some other means, likely just the linker omitting compilation units with no incoming references. (This was previously landed as revisions 10046 and 10060, and got reverted because it broke several of the Chromium FYI bots.) BUG=webrtc:4557 Review URL: https://codereview.webrtc.org/1368843003 Cr-Commit-Position: refs/heads/master@{#10127}
This commit is contained in:
@ -11,12 +11,7 @@
|
||||
'audio_coding_dependencies': [
|
||||
'cng',
|
||||
'g711',
|
||||
'g722',
|
||||
'ilbc',
|
||||
'isac',
|
||||
'isac_fix',
|
||||
'pcm16b',
|
||||
'red',
|
||||
'<(webrtc_root)/common.gyp:webrtc_common',
|
||||
'<(webrtc_root)/common_audio/common_audio.gyp:common_audio',
|
||||
'<(webrtc_root)/system_wrappers/system_wrappers.gyp:system_wrappers',
|
||||
@ -27,6 +22,23 @@
|
||||
'audio_coding_dependencies': ['webrtc_opus',],
|
||||
'audio_coding_defines': ['WEBRTC_CODEC_OPUS',],
|
||||
}],
|
||||
['build_with_mozilla==0', {
|
||||
'conditions': [
|
||||
['target_arch=="arm"', {
|
||||
'audio_coding_dependencies': ['isac_fix',],
|
||||
'audio_coding_defines': ['WEBRTC_CODEC_ISACFX',],
|
||||
}, {
|
||||
'audio_coding_dependencies': ['isac',],
|
||||
'audio_coding_defines': ['WEBRTC_CODEC_ISAC',],
|
||||
}],
|
||||
],
|
||||
'audio_coding_dependencies': ['g722',],
|
||||
'audio_coding_defines': ['WEBRTC_CODEC_G722',],
|
||||
}],
|
||||
['build_with_mozilla==0 and build_with_chromium==0', {
|
||||
'audio_coding_dependencies': ['ilbc', 'red',],
|
||||
'audio_coding_defines': ['WEBRTC_CODEC_ILBC', 'WEBRTC_CODEC_RED',],
|
||||
}],
|
||||
],
|
||||
},
|
||||
'targets': [
|
||||
|
Reference in New Issue
Block a user