zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert of flag simplification.

Browse Source 
In order to unify WebRTC recipes with Chromium recipes this CL tries to revert the old CL https://webrtc-review.googlesource.com/c/src/+/171681.
This CL was already partially reverted (https://webrtc-review.googlesource.com/c/src/+/171809).
In upcoming CLs, the added flag dump_json_test_results will be removed in order to use isolated-script-test-output instead.

Bug: webrtc:13556
Change-Id: I3144498b9a5cbaa56c23b3b8adbac2229ad63c37
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/245602
Reviewed-by: Andrey Logvin <landrey@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#35666}
This commit is contained in:
Jeremy Leconte
2022-01-12 10:51:16 +01:00
committed by WebRTC LUCI CQ
parent ba38934771
commit 994bf454ec
4 changed files with 173 additions and 145 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
test/test_main_lib.cc
View File

@ -59,6 +59,11 @@ ABSL_FLAG(
#else
ABSL_FLAG(std::string,
isolated_script_test_output,
"",
"Path to output an empty JSON file which Chromium infra requires.");
ABSL_FLAG(
std::string,
isolated_script_test_perf_output,
@ -232,6 +237,14 @@ class TestMainImpl : public TestMain {
if (metrics_to_plot) {
webrtc::test::PrintPlottableResults(*metrics_to_plot);
}
std::string result_filename =
absl::GetFlag(FLAGS_isolated_script_test_output);
if (!result_filename.empty()) {
std::ofstream result_file(result_filename);
result_file << "{\"version\": 3}";
result_file.close();
}
#endif
if (capture_events) {