zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix issues found by gn check.

Browse Source 
It turns out that some headers were not owned by any targets.
These were:
RTCVideoCodec.h
RTCVideoCodecFactory.h
RTCVideoCodecH264.h
RTCVideoEncoderVP8.h
RTCVideoDecoderVP8.h
RTCVideoEncoderVP9.h
RTCVideoDecoderVP9.h

And some were owned by multiple targets, namely:
RTCPeerConnectionFactory+Native.h
RTCPeerConnectionFactory+Private.h
RTCVideoFrameBuffer.h

These have all been moved to their appropriate homes.

This CL also fixes a lot of cyclic interdependencies in the iOS sdk build files.

Bug: webrtc:8855
Change-Id: I1b7ddb6c2a93868d1510ccf0a64bd3dd169ec3e7
Reviewed-on: https://webrtc-review.googlesource.com/49060
Reviewed-by: Anders Carlsson <andersc@webrtc.org>
Reviewed-by: Tommi <tommi@webrtc.org>
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Kári Helgason <kthelgason@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22052}
This commit is contained in:
Kári Tristan Helgason
2018-02-16 10:49:22 +01:00
committed by Commit Bot
parent ad148a36ea
commit 99bf77c851
5 changed files with 184 additions and 135 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
modules/video_coding/BUILD.gn
View File

@ -487,8 +487,7 @@ if (rtc_include_tests) {
"../../rtc_base:rtc_base_approved",
"../../sdk:common_objc",
"../../sdk:native_api",
"../../sdk:peerconnection_objc",
"../../sdk:peerconnectionfactory_objc",
"../../sdk:peerconnectionfactory_base_objc",
"../../sdk:videotoolbox_objc",
"../../sdk:videotracksource_objc",
]