zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Increase the threshold for CallPerfTest.CaptureNtpTimeWithNetworkDelay to avoid flaky.

Browse Source 
BUG=3374
R=stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/19529004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6267 4adac7df-926f-26a2-2b94-8c16560cd09d
This commit is contained in:
wu@webrtc.org
2014-05-29 05:03:52 +00:00
parent d6a0efdc86
commit 9aa7d8df95
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
webrtc/video/call_perf_tests.cc
View File

@ -516,14 +516,12 @@ void CallPerfTest::TestCaptureNtpTime(const FakeNetworkPipe::Config& net_config,
receiver_call->DestroyVideoReceiveStream(receive_stream); receiver_call->DestroyVideoReceiveStream(receive_stream);
} }
// Disabled due to being flaky, see issue 3374: TEST_F(CallPerfTest, CaptureNtpTimeWithNetworkDelay) {
// https://code.google.com/p/webrtc/issues/detail?id=3374
TEST_F(CallPerfTest, DISABLED_CaptureNtpTimeWithNetworkDelay) {
FakeNetworkPipe::Config net_config; FakeNetworkPipe::Config net_config;
net_config.queue_delay_ms = 100; net_config.queue_delay_ms = 100;
// TODO(wu): lower the threshold as the calculation/estimatation becomes more // TODO(wu): lower the threshold as the calculation/estimatation becomes more
// accurate. // accurate.
const int kThresholdMs = 30; const int kThresholdMs = 100;
const int kStartTimeMs = 10000; const int kStartTimeMs = 10000;
const int kRunTimeMs = 20000; const int kRunTimeMs = 20000;
TestCaptureNtpTime(net_config, kThresholdMs, kStartTimeMs, kRunTimeMs); TestCaptureNtpTime(net_config, kThresholdMs, kStartTimeMs, kRunTimeMs);