zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add PRESUBMIT to enforce usage of new Googletest APIs.

Browse Source 
Example of an error:
** Presubmit ERRORS **
Usage of legacy GoogleTest API detected!
Please use the new API: https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature.
Affected files:

  rtc_base/ssl_stream_adapter_unittest.cc (line 1459)

Bug: None
No-Try: True
Change-Id: Ibe8fbbc6c3205a266fc75afb5b59721a6b69f240
Reviewed-on: https://webrtc-review.googlesource.com/c/120924
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26562}
This commit is contained in:
Mirko Bonadei
2019-02-05 16:48:13 +01:00
committed by Commit Bot
parent 12d1285707
commit 9ce800d6d1
1 changed files with 22 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
PRESUBMIT.py
View File

@ -449,6 +449,26 @@ def CheckNoWarningSuppressionFlagsAreAdded(gn_files, input_api, output_api,
return [output_api.PresubmitError(msg, errors)] return [output_api.PresubmitError(msg, errors)]
return [] return []
def CheckNoTestCaseUsageIsAdded(input_api, output_api, source_file_filter,
error_formatter=_ReportFileAndLine):
error_msg = ('Usage of legacy GoogleTest API detected!\nPlease use the '
'new API: https://github.com/google/googletest/blob/master/'
'googletest/docs/primer.md#beware-of-the-nomenclature.\n'
'Affected files:\n')
errors = [] # 2-element tuples with (file, line number)
test_case_re = input_api.re.compile(r'TEST_CASE')
file_filter = lambda f: (source_file_filter(f)
and f.LocalPath().endswith('.cc'))
for f in input_api.AffectedSourceFiles(file_filter):
for line_num, line in f.ChangedContents():
if test_case_re.search(line):
errors.append(error_formatter(f.LocalPath(), line_num))
if errors:
return [output_api.PresubmitError(error_msg, errors)]
return []
def CheckNoStreamUsageIsAdded(input_api, output_api, def CheckNoStreamUsageIsAdded(input_api, output_api,
source_file_filter, source_file_filter,
error_formatter=_ReportFileAndLine): error_formatter=_ReportFileAndLine):
@ -860,6 +880,8 @@ def CommonChecks(input_api, output_api):
input_api, output_api, source_file_filter=non_third_party_sources)) input_api, output_api, source_file_filter=non_third_party_sources))
results.extend(CheckNoStreamUsageIsAdded( results.extend(CheckNoStreamUsageIsAdded(
input_api, output_api, non_third_party_sources)) input_api, output_api, non_third_party_sources))
results.extend(CheckNoTestCaseUsageIsAdded(
input_api, output_api, non_third_party_sources))
results.extend(CheckAddedDepsHaveTargetApprovals(input_api, output_api)) results.extend(CheckAddedDepsHaveTargetApprovals(input_api, output_api))
results.extend(CheckApiDepsFileIsUpToDate(input_api, output_api)) results.extend(CheckApiDepsFileIsUpToDate(input_api, output_api))
results.extend(CheckAbslMemoryInclude( results.extend(CheckAbslMemoryInclude(