zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make error message more actionable.

Browse Source 
When the assertion triggers, manual action is likely needed. This
CL changes the error message to make it more clear.

No-Try: True
Bug: webrtc:11369
Change-Id: I7d8b04deef7638e715b12e6dceeee9cc2ce2cc66
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168761
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#30553}
This commit is contained in:
Mirko Bonadei
2020-02-19 09:38:59 +01:00
committed by Commit Bot
parent 4256df09bf
commit 9d3626d15d
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tools_webrtc/autoroller/roll_deps.py
View File

@ -261,7 +261,9 @@ def BuildDepsentryDict(deps_dict):
def _FindChangedCipdPackages(path, old_pkgs, new_pkgs): def _FindChangedCipdPackages(path, old_pkgs, new_pkgs):
pkgs_equal = ({p['package'] for p in old_pkgs} == pkgs_equal = ({p['package'] for p in old_pkgs} ==
{p['package'] for p in new_pkgs}) {p['package'] for p in new_pkgs})
assert pkgs_equal, 'Old: %s\n New: %s' % (old_pkgs, new_pkgs) assert pkgs_equal, ('Old: %s\n New: %s.\nYou need to do a manual roll '
'and remove/add entries in DEPS so the old and new '
'list match.' % (old_pkgs, new_pkgs))
for old_pkg in old_pkgs: for old_pkg in old_pkgs:
for new_pkg in new_pkgs: for new_pkg in new_pkgs:
old_version = old_pkg['version'] old_version = old_pkg['version']