zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert of Disabling NOTREACHED which we're hitting flakily in browser tests. (patchset #1 id:1 of https://codereview.webrtc.org/2477663002/ )

Browse Source 
Reason for revert:
To see if the NOTREACHED is still hit.

Original issue's description:
> Disabling NOTREACHED which we're hitting flakily in browser tests.
>
> I have no idea how bad it is that we're hitting this limit; I'm just
> doing this to stop the tests from flaking.
>
> BUG=webrtc:6484
>
> Committed: https://crrev.com/6eaa55867b449df992752c1df540ec42f9d9b057
> Cr-Commit-Position: refs/heads/master@{#14974}

TBR=stefan@webrtc.org,phoglund@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:6484

Review-Url: https://codereview.webrtc.org/2585183002
Cr-Commit-Position: refs/heads/master@{#15665}
This commit is contained in:
asapersson
2016-12-18 23:47:04 -08:00
committed by Commit bot
parent b2d5577caf
commit 9d7ea0920c
1 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
webrtc/modules/video_coding/codecs/vp9/vp9_frame_buffer_pool.cc
View File

@ -73,10 +73,7 @@ Vp9FrameBufferPool::GetFrameBuffer(size_t min_size) {
<< allocated_buffers_.size() << " Vp9FrameBuffers have been "
<< "allocated by a Vp9FrameBufferPool (exceeding what is "
<< "considered reasonable, " << max_num_buffers_ << ").";
// TODO(phoglund): this limit is being hit in tests since Oct 5 2016.
// See https://bugs.chromium.org/p/webrtc/issues/detail?id=6484.
// RTC_NOTREACHED();
RTC_NOTREACHED();
}
}
}