zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Delete unneeded direct includes of common_types.h

Browse Source 
And delete corresponding dependencies on :webrtc_common. After this
change, common_types.h is included directly only from code in the
following directories:

api/
api/video/
api/video_codecs/
common_video/libyuv/include/
media/base/
modules/remote_bitrate_estimator/
modules/rtp_rtcp/source/
modules/video_coding/codecs/vp9/

There remains plenty of indirect dependencies on the types declared in
common_types.h, but the fewer direct dependencies should make it
easier to find the proper place for each type.

Bug: webrtc:5876
Change-Id: I93e8f214025ecb613c19fdec2015bd3f96c59aae
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/130501
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27376}
This commit is contained in:
Niels Möller
2019-03-29 10:39:41 +01:00
committed by Commit Bot
parent 89cd0c0450
commit 9d8eaac4ee
125 changed files with 1 additions and 177 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
modules/video_coding/codecs/h264/h264.cc
View File

@ -16,7 +16,6 @@
#include "absl/memory/memory.h"
#include "absl/types/optional.h"
#include "api/video_codecs/sdp_video_format.h"
#include "common_types.h" // NOLINT(build/include)
#include "media/base/h264_profile_level_id.h"
#include "media/base/media_constants.h"

1
modules/video_coding/codecs/h264/test/h264_impl_unittest.cc
View File

@ -18,7 +18,6 @@
#include "api/video_codecs/video_codec.h"
#include "api/video_codecs/video_decoder.h"
#include "api/video_codecs/video_encoder.h"
#include "common_types.h" // NOLINT(build/include)
#include "common_video/libyuv/include/webrtc_libyuv.h"
#include "common_video/test/utilities.h"
#include "media/base/codec.h"

1
modules/video_coding/codecs/multiplex/multiplex_encoded_image_packer.h
View File

@ -16,7 +16,6 @@
#include <vector>
#include "api/video/encoded_image.h"
#include "common_types.h" // NOLINT(build/include)
namespace webrtc {

1
modules/video_coding/codecs/multiplex/test/multiplex_adapter_unittest.cc
View File

@ -27,7 +27,6 @@
#include "api/video_codecs/video_codec.h"
#include "api/video_codecs/video_decoder.h"
#include "api/video_codecs/video_encoder.h"
#include "common_types.h" // NOLINT(build/include)
#include "common_video/include/video_frame_buffer.h"
#include "common_video/libyuv/include/webrtc_libyuv.h"
#include "media/base/media_constants.h"

1
modules/video_coding/codecs/test/video_codec_unittest.cc
View File

@ -10,7 +10,6 @@
#include <utility>
#include "common_types.h" // NOLINT(build/include)
#include "modules/rtp_rtcp/include/rtp_rtcp_defines.h"
#include "modules/video_coding/codecs/test/video_codec_unittest.h"
#include "modules/video_coding/include/video_error_codes.h"

1
modules/video_coding/codecs/test/video_encoder_decoder_instantiation_tests.cc
View File

@ -16,7 +16,6 @@
#include "api/video_codecs/video_decoder_factory.h"
#include "api/video_codecs/video_encoder.h"
#include "api/video_codecs/video_encoder_factory.h"
#include "common_types.h" // NOLINT(build/include)
#if defined(WEBRTC_ANDROID)
#include "modules/video_coding/codecs/test/android_codec_factory_helper.h"
#elif defined(WEBRTC_IOS)

1
modules/video_coding/codecs/test/videocodec_test_fixture_config_unittest.cc
View File

@ -12,7 +12,6 @@
#include "api/test/videocodec_test_fixture.h"
#include "api/video_codecs/video_codec.h"
#include "common_types.h" // NOLINT(build/include)
#include "test/gmock.h"
#include "test/gtest.h"
#include "test/video_codec_settings.h"

1
modules/video_coding/codecs/test/videocodec_test_fixture_impl.cc
View File

@ -26,7 +26,6 @@
#include "api/video_codecs/video_codec.h"
#include "api/video_codecs/video_decoder.h"
#include "api/video_codecs/video_encoder_config.h"
#include "common_types.h" // NOLINT(build/include)
#include "common_video/h264/h264_common.h"
#include "media/base/h264_profile_level_id.h"
#include "media/base/media_constants.h"

1
modules/video_coding/codecs/test/videocodec_test_fixture_impl.h
View File

@ -18,7 +18,6 @@
#include "api/test/videocodec_test_fixture.h"
#include "api/video_codecs/video_decoder_factory.h"
#include "api/video_codecs/video_encoder_factory.h"
#include "common_types.h" // NOLINT(build/include)
#include "common_video/h264/h264_common.h"
#include "modules/video_coding/codecs/test/videocodec_test_stats_impl.h"
#include "modules/video_coding/codecs/test/videoprocessor.h"

1
modules/video_coding/codecs/test/videocodec_test_mediacodec.cc
View File

@ -14,7 +14,6 @@
#include "absl/memory/memory.h"
#include "api/test/create_videocodec_test_fixture.h"
#include "common_types.h" // NOLINT(build/include)
#include "media/base/media_constants.h"
#include "modules/video_coding/codecs/test/android_codec_factory_helper.h"
#include "modules/video_coding/codecs/test/videocodec_test_fixture_impl.h"

1
modules/video_coding/codecs/test/videoprocessor.cc
View File

@ -24,7 +24,6 @@
#include "api/video/video_frame_buffer.h"
#include "api/video/video_rotation.h"
#include "api/video_codecs/video_codec.h"
#include "common_types.h" // NOLINT(build/include)
#include "common_video/h264/h264_common.h"
#include "common_video/libyuv/include/webrtc_libyuv.h"
#include "modules/rtp_rtcp/include/rtp_rtcp_defines.h"

1
modules/video_coding/codecs/test/videoprocessor.h
View File

@ -29,7 +29,6 @@
#include "api/video/video_frame.h"
#include "api/video_codecs/video_decoder.h"
#include "api/video_codecs/video_encoder.h"
#include "common_types.h" // NOLINT(build/include)
#include "modules/include/module_common_types.h"
#include "modules/video_coding/codecs/test/videocodec_test_stats_impl.h"
#include "modules/video_coding/include/video_codec_interface.h"

1
modules/video_coding/codecs/vp8/default_temporal_layers_unittest.cc
View File

@ -16,7 +16,6 @@
#include "api/video/video_bitrate_allocation.h"
#include "api/video_codecs/video_codec.h"
#include "api/video_codecs/vp8_frame_config.h"
#include "common_types.h" // NOLINT(build/include)
#include "modules/video_coding/codecs/vp8/libvpx_vp8_encoder.h"
#include "modules/video_coding/include/video_codec_interface.h"
#include "modules/video_coding/utility/simulcast_rate_allocator.h"

1
modules/video_coding/codecs/vp8/libvpx_vp8_decoder.cc
View File

@ -20,7 +20,6 @@
#include "api/video/video_frame.h"
#include "api/video/video_frame_buffer.h"
#include "api/video/video_rotation.h"
#include "common_types.h" // NOLINT(build/include)
#include "modules/video_coding/codecs/vp8/include/vp8.h"
#include "modules/video_coding/codecs/vp8/libvpx_vp8_decoder.h"
#include "modules/video_coding/include/video_error_codes.h"

1
modules/video_coding/codecs/vp8/libvpx_vp8_decoder.h
View File

@ -15,7 +15,6 @@
#include "api/video/encoded_image.h"
#include "api/video_codecs/video_decoder.h"
#include "common_types.h" // NOLINT(build/include)
#include "common_video/include/i420_buffer_pool.h"
#include "modules/include/module_common_types.h"
#include "modules/video_coding/codecs/vp8/include/vp8.h"

1
modules/video_coding/codecs/vp8/libvpx_vp8_encoder.h
View File

@ -20,7 +20,6 @@
#include "api/video_codecs/video_encoder.h"
#include "api/video_codecs/vp8_frame_buffer_controller.h"
#include "api/video_codecs/vp8_frame_config.h"
#include "common_types.h" // NOLINT(build/include)
#include "modules/video_coding/codecs/vp8/include/vp8.h"
#include "modules/video_coding/codecs/vp8/libvpx_interface.h"
#include "modules/video_coding/include/video_codec_interface.h"

1
modules/video_coding/codecs/vp9/svc_rate_allocator.cc
View File

@ -15,7 +15,6 @@
#include <cstddef>
#include <numeric>
#include "common_types.h" // NOLINT(build/include)
#include "rtc_base/checks.h"
namespace webrtc {

1
modules/video_coding/codecs/vp9/svc_rate_allocator_unittest.cc
View File

@ -10,7 +10,6 @@
#include <algorithm>
#include "common_types.h" // NOLINT(build/include)
#include "modules/video_coding/codecs/vp9/svc_config.h"
#include "modules/video_coding/codecs/vp9/svc_rate_allocator.h"
#include "rtc_base/checks.h"