Delete unneeded direct includes of common_types.h
And delete corresponding dependencies on :webrtc_common. After this change, common_types.h is included directly only from code in the following directories: api/ api/video/ api/video_codecs/ common_video/libyuv/include/ media/base/ modules/remote_bitrate_estimator/ modules/rtp_rtcp/source/ modules/video_coding/codecs/vp9/ There remains plenty of indirect dependencies on the types declared in common_types.h, but the fewer direct dependencies should make it easier to find the proper place for each type. Bug: webrtc:5876 Change-Id: I93e8f214025ecb613c19fdec2015bd3f96c59aae Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/130501 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27376}
This commit is contained in:
@ -11,7 +11,6 @@
|
||||
#include <limits>
|
||||
#include <memory>
|
||||
|
||||
#include "common_types.h" // NOLINT(build/include)
|
||||
#include "modules/video_coding/utility/default_video_bitrate_allocator.h"
|
||||
#include "test/gtest.h"
|
||||
|
||||
|
||||
@ -16,7 +16,6 @@
|
||||
#include <memory>
|
||||
|
||||
#include "api/video/encoded_image.h"
|
||||
#include "common_types.h" // NOLINT(build/include)
|
||||
#include "rtc_base/constructor_magic.h"
|
||||
#include "rtc_base/system/file_wrapper.h"
|
||||
#include "rtc_base/time_utils.h"
|
||||
|
||||
@ -18,7 +18,6 @@
|
||||
#include <tuple>
|
||||
#include <vector>
|
||||
|
||||
#include "common_types.h" // NOLINT(build/include)
|
||||
#include "rtc_base/checks.h"
|
||||
#include "rtc_base/experiments/rate_control_settings.h"
|
||||
#include "system_wrappers/include/field_trial.h"
|
||||
|
||||
@ -21,7 +21,6 @@
|
||||
#include "api/video/video_frame.h"
|
||||
#include "api/video_codecs/video_decoder_factory.h"
|
||||
#include "api/video_codecs/video_encoder_factory.h"
|
||||
#include "common_types.h" // NOLINT(build/include)
|
||||
#include "modules/video_coding/utility/simulcast_rate_allocator.h"
|
||||
|
||||
namespace webrtc {
|
||||
|
||||
@ -12,7 +12,6 @@
|
||||
|
||||
#include <cmath>
|
||||
|
||||
#include "common_types.h" // NOLINT(build/include)
|
||||
#include "modules/video_coding/utility/simulcast_utility.h"
|
||||
#include "rtc_base/checks.h"
|
||||
|
||||
|
||||
Reference in New Issue
Block a user