zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Delete BasicPacketSocketFactory constructor with thread argument

Browse Source 
In callers where it's non-trivial to explicitly pass the right
SocketFactory, pull the call to rtc::Thread::socketserver() into the
caller, with a TODO comment.

Bug: webrtc:13145
Change-Id: I029d3adca385d822180e089f016c3778e0d4fd0c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/231227
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35063}
This commit is contained in:
Niels Möller
2021-09-07 09:16:49 +02:00
committed by WebRTC LUCI CQ
parent 070dbe13d1
commit 9def99487e
11 changed files with 26 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
rtc_tools/network_tester/test_controller.cc
View File

@ -23,7 +23,9 @@ TestController::TestController(int min_port,
int max_port,
const std::string& config_file_path,
const std::string& log_file_path)
: socket_factory_(rtc::ThreadManager::Instance()->WrapCurrentThread()),
// TODO(bugs.webrtc.org/13145): Add a SocketFactory argument.
: socket_factory_(
rtc::ThreadManager::Instance()->WrapCurrentThread()->socketserver()),
config_file_path_(config_file_path),
packet_logger_(log_file_path),
local_test_done_(false),