zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Injectable Obj-C video codecs

Browse Source 
Initial CL for this effort, with a working RTCVideoEncoder/Decoder for H264
(wrapping the VideoToolbox codec).

Some notes / things left to do:
  - There are some hard-coded references to codec types that are supported by
    webrtc::VideoCodec, cricket::VideoCodec, webrtc::CodecSpecificInfo etc
    since we need to convert to/from these types in ObjCVideoEncoder/Decoder.
    These types would need to be more codec agnostic to avoid this.
  - Most interfaces are borrowed from the design document for injectable
    codecs in Android. Some data in the corresponding C++ classes is discarded
    when converting to the Obj-C version, since it has fewer fields. I have not
    verified whether all data that we do keep is needed, or whether we might be
    losing anything useful in these conversions.
  - Implement the VideoToolbox codec code directly in the RTCVideoEncoderH264
    classes, instead of wrapping webrtc::H264VideoToolboxEncoder / decoder.
    Eliminates converting between ObjC/C++ types outside the ObjCVideoEncoder/
    Decoder wrapper classes.
  - List the injected codec factory's supported codecs in the list of codecs in
    AppRTCMobile.

BUG=webrtc:7924
R=magjed@webrtc.org

Review-Url: https://codereview.webrtc.org/2966023002 .
Cr-Commit-Position: refs/heads/master@{#18928}
This commit is contained in:
Anders Carlsson
2017-07-07 13:19:09 +02:00
parent c1a58bae41
commit a0349c138d
19 changed files with 1214 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
webrtc/sdk/objc/Framework/Classes/Common/helpers.h
View File

@ -11,8 +11,6 @@
#ifndef WEBRTC_SDK_OBJC_FRAMEWORK_CLASSES_COMMON_HELPERS_H_
#define WEBRTC_SDK_OBJC_FRAMEWORK_CLASSES_COMMON_HELPERS_H_
#if defined(WEBRTC_IOS)
#include <string>
namespace webrtc {
@ -33,6 +31,7 @@ std::string GetThreadInfo();
// Example: <NSThread: 0x170066d80>{number = 1, name = main}
std::string GetCurrentThreadDescription();
#if defined(WEBRTC_IOS)
// Returns the current name of the operating system.
std::string GetSystemName();
@ -46,6 +45,7 @@ double GetSystemVersion();
// Returns the device type.
// Examples: ”iPhone” and ”iPod touch”.
std::string GetDeviceType();
#endif // defined(WEBRTC_IOS)
// Returns a more detailed device name.
// Examples: "iPhone 5s (GSM)" and "iPhone 6 Plus".
@ -65,12 +65,12 @@ std::string GetOSVersionString();
// Returns the number of processing cores available on the device.
int GetProcessorCount();
#if defined(WEBRTC_IOS)
// Indicates whether Low Power Mode is enabled on the iOS device.
bool GetLowPowerModeEnabled();
#endif
} // namespace ios
} // namespace webrtc
#endif // defined(WEBRTC_IOS)
#endif // WEBRTC_SDK_OBJC_FRAMEWORK_CLASSES_COMMON_HELPERS_H_