zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Stop silently accepting unsupported flags in test binaries

Browse Source 
Instead explicitly ignore only the flags we know should be ignored.

BUG=webrtc:7568

Review-Url: https://codereview.webrtc.org/2968003003
Cr-Commit-Position: refs/heads/master@{#19412}
This commit is contained in:
oprypin
2017-08-18 07:12:20 -07:00
committed by Commit Bot
parent 81bc523f5d
commit a2782f6f5d
5 changed files with 21 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
webrtc/modules/audio_coding/codecs/isac/fix/test/kenny.cc
View File

@ -384,10 +384,8 @@ TEST(IsacFixTest, Kenny) {
sscanf(argv[CodingMode+1], "%s", bottleneck_file);
f_bn = fopen(bottleneck_file, "rb");
if (f_bn == NULL) {
printf("No value provided for BottleNeck and cannot read file %s\n",
bottleneck_file);
exit(0); // TODO(oprypin): don't silence this error
// FAIL() << "Cannot read file " << bottleneck_file;
printf("No value provided for BottleNeck\n");
FAIL() << "Cannot read file " << bottleneck_file;
} else {
int aux_var;
printf("reading bottleneck rates from file %s\n\n",bottleneck_file);