zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Disable H264 videotoolbox unit tests on iOS builds.

Browse Source 
The tests fail when running on internal test bots.

Bug: webrtc:9099
Change-Id: I89a537fe46ac56891f90e9722055218fd9e87ecf
Reviewed-on: https://webrtc-review.googlesource.com/66400
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22723}
This commit is contained in:
Sergey Silkin
2018-04-03 12:15:12 +02:00
committed by Commit Bot
parent 2a1f183e99
commit a31018090e
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
modules/video_coding/codecs/test/videoprocessor_integrationtest_videotoolbox.cc
View File

@ -35,12 +35,13 @@ class VideoProcessorIntegrationTestVideoToolbox
}
};
// TODO(webrtc:9099): Disabled until the issue is fixed.
// HW codecs don't work on simulators. Only run these tests on device.
#if TARGET_OS_IPHONE && !TARGET_IPHONE_SIMULATOR
#define MAYBE_TEST_F TEST_F
#else
// #if TARGET_OS_IPHONE && !TARGET_IPHONE_SIMULATOR
// #define MAYBE_TEST_F TEST_F
// #else
#define MAYBE_TEST_F(s, name) TEST_F(s, DISABLED_##name)
#endif
// #endif
// TODO(kthelgason): Use RC Thresholds when the internal bitrateAdjuster is no
// longer in use.