zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add a new PeerConnectionE2EQualityTestFixture::AddPeer method.

Browse Source 
Change-Id: Ic5879613db51a00e3e958931f5eda19fda1ae94a
Bug: webrtc:14627
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/282640
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38608}
This commit is contained in:
Jeremy Leconte
2022-11-10 15:42:53 +01:00
committed by WebRTC LUCI CQ
parent c97651cbb4
commit a3e51df5f3
14 changed files with 110 additions and 71 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
api/BUILD.gn
View File

@ -547,6 +547,7 @@ rtc_source_set("peer_connection_quality_test_fixture_api") {
"video_codecs:video_codecs_api",
]
absl_deps = [
"//third_party/abseil-cpp/absl/base:core_headers",
"//third_party/abseil-cpp/absl/memory",
"//third_party/abseil-cpp/absl/strings",
"//third_party/abseil-cpp/absl/types:optional",

14
api/test/peerconnection_quality_test_fixture.h
View File

@ -20,6 +20,7 @@
#include <utility>
#include <vector>
#include "absl/base/macros.h"
#include "absl/memory/memory.h"
#include "absl/strings/string_view.h"
#include "absl/types/optional.h"
@ -132,9 +133,18 @@ class PeerConnectionE2EQualityTestFixture {
// `network_dependencies` are used to provide networking for peer's peer
// connection. Members must be non-null.
// `configurer` function will be used to configure peer in the call.
virtual PeerHandle* AddPeer(
[[deprecated("bugs.webrtc.org/14627")]] virtual PeerHandle* AddPeer(
const PeerNetworkDependencies& network_dependencies,
rtc::FunctionView<void(PeerConfigurer*)> configurer) = 0;
rtc::FunctionView<void(PeerConfigurer*)> configurer) {
RTC_CHECK_NOTREACHED();
return nullptr;
}
// TODO(bugs.webrtc.org/14627): make pure virtual once all subclasses
// implement it.
virtual PeerHandle* AddPeer(std::unique_ptr<PeerConfigurer> configurer) {
RTC_CHECK_NOTREACHED();
return nullptr;
}
// Runs the media quality test, which includes setting up the call with
// configured participants, running it according to provided `run_params` and