zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Log an error if the RTT is negative

Browse Source 
Bug: webrtc:10407
Change-Id: I5479cb2b7163c6e9e58854f4ffa7976b3d606da5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127568
Commit-Queue: Evan Shrubsole <eshr@google.com>
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27122}
This commit is contained in:
Evan Shrubsole
2019-03-13 16:38:38 +01:00
committed by Commit Bot
parent d841ea6b58
commit a594ef0893
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
modules/congestion_controller/goog_cc/goog_cc_network_control.cc
View File

@ -381,6 +381,11 @@ NetworkControlUpdate GoogCcNetworkController::OnTransportPacketsFeedback(
for (const auto& feedback : feedbacks) { for (const auto& feedback : feedbacks) {
TimeDelta feedback_rtt = TimeDelta feedback_rtt =
report.feedback_time - feedback.sent_packet.send_time; report.feedback_time - feedback.sent_packet.send_time;
// TODO(bugs.webrtc.org/10407): This should be a DCHECK and never happen
if (feedback_rtt < TimeDelta::Zero())
RTC_LOG(LS_ERROR) << "negative rtt detected send_time_ms="
<< feedback.sent_packet.send_time.ms()
<< " feedback_time_ms=" << report.feedback_time.ms();
TimeDelta min_pending_time = feedback.receive_time - max_recv_time; TimeDelta min_pending_time = feedback.receive_time - max_recv_time;
TimeDelta propagation_rtt = feedback_rtt - min_pending_time; TimeDelta propagation_rtt = feedback_rtt - min_pending_time;
max_feedback_rtt = std::max(max_feedback_rtt, feedback_rtt); max_feedback_rtt = std::max(max_feedback_rtt, feedback_rtt);