zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Separating internal and external methods of RtpSender/RtpReceiver.

Browse Source 
This moves the implementation specific methods to separate classes
(RtpSenderInternal/RtpReceiverInternal) so that the interface classes
represent the interface that external applications can rely on.

The reason this wasn't done earlier was that PeerConnection needed
to store proxy pointers, but also needed to access implementation-
specific methods on the underlying objects. This is now possible
by using "RtpSenderProxyWithInternal<RtpSenderInternal>", which is a proxy
that implements RtpSenderInterface but also provides direct access
to an RtpSenderInternal.

Review-Url: https://codereview.webrtc.org/2023373002
Cr-Commit-Position: refs/heads/master@{#13056}
This commit is contained in:
deadbeef
2016-06-06 14:27:39 -07:00
committed by Commit bot
parent aff499c9bf
commit a601f5c863
11 changed files with 268 additions and 194 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
webrtc/api/rtpreceiver.h
View File

@ -26,9 +26,15 @@
namespace webrtc {
// Internal class used by PeerConnection.
class RtpReceiverInternal : public RtpReceiverInterface {
public:
virtual void Stop() = 0;
};
class AudioRtpReceiver : public ObserverInterface,
public AudioSourceInterface::AudioObserver,
public rtc::RefCountedObject<RtpReceiverInterface> {
public rtc::RefCountedObject<RtpReceiverInternal> {
public:
AudioRtpReceiver(MediaStreamInterface* stream,
const std::string& track_id,
@ -54,11 +60,12 @@ class AudioRtpReceiver : public ObserverInterface,
std::string id() const override { return id_; }
void Stop() override;
RtpParameters GetParameters() const override;
bool SetParameters(const RtpParameters& parameters) override;
// RtpReceiverInternal implementation.
void Stop() override;
private:
void Reconfigure();
@ -69,7 +76,7 @@ class AudioRtpReceiver : public ObserverInterface,
bool cached_track_enabled_;
};
class VideoRtpReceiver : public rtc::RefCountedObject<RtpReceiverInterface> {
class VideoRtpReceiver : public rtc::RefCountedObject<RtpReceiverInternal> {
public:
VideoRtpReceiver(MediaStreamInterface* stream,
const std::string& track_id,
@ -90,11 +97,12 @@ class VideoRtpReceiver : public rtc::RefCountedObject<RtpReceiverInterface> {
std::string id() const override { return id_; }
void Stop() override;
RtpParameters GetParameters() const override;
bool SetParameters(const RtpParameters& parameters) override;
// RtpReceiverInternal implementation.
void Stop() override;
private:
std::string id_;
uint32_t ssrc_;